Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 8 years ago

We decided to remove createObjectURL from ServiceWorker context since blob URLs have lifecycle problems on service workers and Response objects have better semantics.

  https://github.com/slightlyoff/ServiceWorker/issues/688

	Yaron Tausky [:ytausky] Assignee
	Comment 1 • 6 years ago

The appropriate lifetime for URLs created with URL.createObjectURL turned
out to be tricky to define, so it was decided to hide it from service
workers altogether. (https://github.com/slightlyoff/ServiceWorker/issues/688)

This commit implements this change and adds a web platform test to verify it.
It also exposes the MediaSource variant of URL.createObjectURL in DedicatedWorker
and SharedWorker contexts in order to comply with the WebIDL spec (see
https://github.com/w3c/media-source/issues/168#issuecomment-410269436).

	Phabricator Automation
	Comment 2 • 6 years ago

Comment on attachment 8997470 [details]
Bug 1264182: Hide URL.createObjectURL from ServiceWorker

Blake Kaplan (:mrbkap) has approved the revision.

https://phabricator.services.mozilla.com/D2728

	Phabricator Automation
	Comment 3 • 6 years ago

Comment on attachment 8997470 [details]
Bug 1264182: Hide URL.createObjectURL from ServiceWorker

Andrew Sutherland [:asuth] has approved the revision.

https://phabricator.services.mozilla.com/D2728

	Pulsebot
	Comment 4 • 6 years ago

Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/40d4999db319
Hide URL.createObjectURL from ServiceWorker r=mrbkap,asuth

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 5 • 6 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12339 for changes under testing/web-platform/tests

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 6 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Cristian Brindusan [:cbrindusan]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/40d4999db319

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 8 • 6 years ago

Upstream PR merged

	Kohei Yoshino [:kohei]
	Comment 9 • 6 years ago

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/url-createobjecturl-is-no-longer-available-in-service-workers/

	Eric Shepherd [:sheppy]
	Comment 10 • 6 years ago

Doc updates:

The createObjectURL() page already had this information; updated revokeObjectURL() and added a note to Firefox 63 for developers.

I've also submitted PR #2707 on BCD to note these changes in the compatibility database.

	Kohei Yoshino [:kohei]
	Comment 11 • 6 years ago

Aha, I’ve just found URL.createObjectURL in my own service worker. Fortunately this particular app is no longer maintained, but I’m wondering if this change may break similar code. Will monitor reports.

https://github.com/bzdeck/bzdeck/blob/master/webroot/static/scripts/workers/service-worker.js