Closed
Bug 1264175
Opened 8 years ago
Closed 4 years ago
Remove FetchEvent.isReload
Categories
(Core :: DOM: Service Workers, task, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla74
People
(Reporter: bkelly, Assigned: perry)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat, Whiteboard: btpp-fixlater)
Attachments
(1 file)
We have decided to remove FetchEvent.isReload in favor of exposing FetchEvent.request.cache policy values: https://github.com/slightlyoff/ServiceWorker/issues/873 I'm filing this now, but we should wait to actually remove it until chrome is ready. Right now they still need to implement RequestCache.
|
||
Updated•8 years ago
|
Whiteboard: btpp-fixlater
|
||
Updated•7 years ago
|
Keywords: dev-doc-needed
|
||
Updated•7 years ago
|
Keywords: site-compat
|
||
Updated•6 years ago
|
Priority: -- → P2
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sbalaji
|
|
||
Updated•4 years ago
|
Type: defect → task
|
||
Comment 1•4 years ago
|
||
:sbalaji seems no longer active. What should we do with this?
Flags: needinfo?(perry)
|
|
Assignee | |
Comment 2•4 years ago
|
||
This is a really quick fix, I'll take it.
Assignee: sbalaji → perry
Flags: needinfo?(perry)
|
|
Assignee | |
Comment 3•4 years ago
|
||
isReload is no longer a property defined by the FetchEvent specification.
|
||
Updated•4 years ago
|
Attachment #9122524 -
Attachment description: Bug 1264175 - remove FetchEvent.isReload r?#dom-workers-and-storage-reviewers → Bug 1264175 - remove FetchEvent.isReload r?#dom-workers-and-storage-reviewers,valentin
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86d1da74131f remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky
|
||
Comment 5•4 years ago
|
||
Backed out changeset 86d1da74131f (Bug 1264175) for causing mochitest failures in dom/serviceworkers/test/test_fetch_event.html CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286283682&repo=autoland&lineNumber=3170
Flags: needinfo?(perry)
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/975f76d04c40 Backed out changeset 86d1da74131f for causing mochitest failures in dom/serviceworkers/test/test_fetch_event.html CLOSED TREE
|
|
Assignee | |
Comment 7•4 years ago
|
||
Fixed dom/serviceworkers/test/test_fetch_event.html
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4719c7553531f864ca05d5d1d3ac4170703800df
Flags: needinfo?(perry)
Pushed by pjiang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df18f76d934a remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky
|
|
||
Comment 9•4 years ago
|
||
Posted site compatibility note.
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
|
||
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
Documentation updated:
- https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/FetchEvent
- https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/74
- Also submitted BCD PR 5728 to mark
isReloadas obsolete.
|
|
||
Updated•4 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•