Ryan VanderMeulen [:RyanVM] Reporter
	Description • 8 years ago

Saw some logspam fly by recently warning about the deprecation. Seems trivial enough to change.

	Andreas Pehrson [:pehrsons] Assignee
	Comment 1 • 8 years ago

Before we can do this we have to

1 change HTMLMediaElement to end when a stream becomes inactive
2 let all tracks (including remote ones) be stoppable. This was recently changed in the spec iirc.

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 2 • 8 years ago

(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #1)
> Before we can do this we have to
> 
> 1 change HTMLMediaElement to end when a stream becomes inactive
> 2 let all tracks (including remote ones) be stoppable. This was recently
> changed in the spec iirc.

Have both of these things happened now?

fippo just alerted me to that Chrome no longer supports MediaStream.stop() and we've had deprecation warnings since 44, so I think it's time to remove this feature from the platform (as well as remove tests, hijacking this bug #).

	Andreas Pehrson [:pehrsons] Assignee
	Comment 3 • 8 years ago

No. But we're close.

	Andreas Pehrson [:pehrsons] Assignee
	Comment 4 • 8 years ago

We're good now. Do you want to kill it already in 52 or wait for 53?

The reason I ask is because bug 1208316 landed in 52 and changed how media elements end when they play MediaStreams. They used to end when the input stream ended, either by chrome or stop(). Though we only had stop() on LocalMediaStream, which only getUserMedia used. Now a media element ends as the MediaStream goes inactive.

We should also kill LocalMediaStream as part of this bug.

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 5 • 8 years ago

Would love to get it in for ESR

	Bulk Bug Changes for mreavy's org
	Comment 6 • 7 years ago

Mass change P1->P2 to align with new Mozilla triage process

	Andreas Pehrson [:pehrsons] Assignee
	Comment 9 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbb51ebfc9d61c8e92ccca8e2928f8b3226a428a

	Pulsebot
	Comment 11 • 6 years ago

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/905c871bcf03
Remove LocalMediaStream. r=jib,smaug
https://hg.mozilla.org/integration/autoland/rev/514420f15a67
Test that MediaStream is the primary interface of a getUserMedia-stream. r=jib

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 12 • 6 years ago

Backed out 2 changesets (Bug 1258143) for dom/media/tests/crashtests/791330.html failures

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=205078511&revision=514420f15a67df92c218191b23a3b4bcd4b7ea95

Backout link: https://hg.mozilla.org/integration/autoland/rev/2fe9ae64504697968b89d5ec4ef0d027a0dc46fa

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205078511&repo=autoland&lineNumber=26647

07:03:32     INFO - --DOMWINDOW == 6 (0x1220bb000) [pid = 795] [serial = 3076] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/test/crashtests/oscillator-ended-2.html]
07:03:32     INFO - --DOMWINDOW == 5 (0x121582c00) [pid = 795] [serial = 3090] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791278.html]
07:03:32     INFO - --DOMWINDOW == 4 (0x12b0c0400) [pid = 795] [serial = 3081] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
07:03:40     INFO - [Parent 789, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x1223f8c70 (http://mzl.la/1FuID0j).: file /builds/worker/workspace/build/src/storage/mozStoragePrivateHelpers.cpp, line 114
07:08:24     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791330.html | load failed: timed out waiting for reftest-wait to be removed
07:08:24     INFO - REFTEST INFO | Saved log: START file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791330.html
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering WaitForTestEnd
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
07:08:24     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791330.html
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] SendUpdateCanvasForEvent with 0 rects
07:08:24     INFO - REFTEST INFO | Saved log: Updating canvas for invalidation
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791330.html
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] SendUpdateCanvasForEvent with 1 rects
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] Rect: 0 0 800 1000
07:08:24     INFO - REFTEST INFO | Saved log: Updating canvas for invalidation
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
07:08:24     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
07:08:24     INFO - REFTEST TEST-END | file:///Users/cltbld/tasks/task_1539352695/build/tests/reftest/tests/dom/media/tests/crashtests/791330.html

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 13 • 6 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13496 for changes under testing/web-platform/tests

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 14 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 15 • 6 years ago

Upstream PR was closed without merging

	Andreas Pehrson [:pehrsons] Assignee
	Comment 16 • 6 years ago

Thanks Bogdan. Looks like I forgot to run crashtests when testing this.

	Pulsebot
	Comment 17 • 6 years ago

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9508a03be7c2
Remove LocalMediaStream. r=jib,smaug
https://hg.mozilla.org/integration/autoland/rev/92b4fac6ea6c
Test that MediaStream is the primary interface of a getUserMedia-stream. r=jib

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 18 • 6 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 19 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9508a03be7c2
https://hg.mozilla.org/mozilla-central/rev/92b4fac6ea6c

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 20 • 6 years ago

Upstream PR merged

	Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)
	Comment 21 • 6 years ago

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13496
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/H9zp5O1xTdO203eD7tpITw)

	Kohei Yoshino [:kohei]
	Comment 22 • 6 years ago

Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/audiostreamtrack-videostreamtrack-and-localmediastream-have-been-removed/

	Chris Mills [:cmills]
	Comment 23 • 6 years ago

Note to docs team:

I've added a note about this to the Fx64 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#APIs

The LocalMediaStream page has already been marked as obsolete. You should delete the page and update BCD.

	Eric Shepherd [:sheppy]
	Comment 24 • 6 years ago

I would prefer not to delete the page outright at this time. Being marked as obsolete is good, and I've added a big note, made some other additions, and changed the page's SEO summary to direct people to information about updating old code to further emphasize matters. I've also updated Firefox 64 for developers to link to that same information.

I've submitted a PR to update BCD. That closes out this issue.