Kevin Brosnan [Ex-Mozilla] Reporter
	Description • 8 years ago

[Tracking Requested - why for this release]: major web feature broken

I have tested several webgl sites and they all report that webgl is non functional.

http://get.webgl.org/
http://doesmybrowsersupportwebgl.com/

From https://support.mozilla.org/en-US/questions/1114216

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 1 • 8 years ago

Works here on Nexus 6P. What hardware are you on?

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 2 • 8 years ago

Works on Nexus 9 and Nexus 4 as well. Not sure what's going on, but logcat from an affected device may help.

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 3 • 8 years ago

Kevin says he says 'GLContext is disabled' type of messages in the logcat, presumably due to the crashes. Milan, I think it makes sense to just disable that stuff on Android, sense no configuration changes (driver upgrades) are really possible.

	Kevin Brosnan [Ex-Mozilla] Reporter
	Comment 4 • 8 years ago

Full logcat

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 5 • 8 years ago

Milan is PTO this week, redirecting to dvander who I believe is working on this stuff.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 6 • 8 years ago

Sounds reasonable.

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 7 • 8 years ago

Comment on attachment 8730363 [details] [diff] [review]
patch

Review of attachment 8730363 [details] [diff] [review]:
-----------------------------------------------------------------

Will this also enable WebGL for people where it has been disabled by the crash guard?

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 8 • 8 years ago

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #7)
> Comment on attachment 8730363 [details] [diff] [review]
> patch
> 
> Review of attachment 8730363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Will this also enable WebGL for people where it has been disabled by the
> crash guard?

Yup.

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 9 • 8 years ago

Comment on attachment 8730363 [details] [diff] [review]
patch

Review of attachment 8730363 [details] [diff] [review]:
-----------------------------------------------------------------

We'll want to uplift this basically everywhere, including release if there is a dot release

	Sylvestre Ledru [:Sylvestre]
	Comment 10 • 8 years ago

James, David, I am going to start the build of dot release very soon, could you fill the uplift request? Thanks

	Pulsebot
	Comment 11 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a1e75dd9d54

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 12 • 8 years ago

Comment on attachment 8730363 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1190281
[User impact if declined]: No WebGL support for users where WebGL crashed.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: No risk, aside from unblocking WebGL for users where it once crashed, so there's a chance they may crash again. This isn't anywhere near as severe as a startup crash which is what the guard was intended to prevent.
[String/UUID change made/needed]:

	Sylvestre Ledru [:Sylvestre]
	Comment 13 • 8 years ago

Comment on attachment 8730363 [details] [diff] [review]
patch

Needed for 45.0.1 fennec

Ryan, very sorry but could you land that? Thanks

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 14 • 8 years ago

I can get it.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 8 years ago

Here's release, I'll get the other trees when I look through the rest of the uplift requests:

https://hg.mozilla.org/releases/mozilla-release/rev/910c9ac881ee

	Pulsebot
	Comment 16 • 8 years ago

https://hg.mozilla.org/mozilla-central/rev/7773387a9a2f

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 17 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7773387a9a2f

	Carsten Book [:Tomcat]
	Comment 18 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54

	Sylvestre Ledru [:Sylvestre]
	Comment 19 • 8 years ago

Added to the release notes with "Bring back WebGL support on some devices (1256371)" as wording

	Carsten Book [:Tomcat]
	Comment 20 • 8 years ago

(In reply to Carsten Book [:Tomcat] from comment #18)
> https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54

dvander so this is the final patch that needs to land on beta and co ?

	u421692
	Comment 21 • 8 years ago

I was able to reproduce this issue on Firefox 45.0 with the following STR: 
1. Install crashme add-on
2. Open http://get.webgl.org/ the very quickly crash Firefox
1/2 times I was able to reproduce the issue

Verified as fixed on Firefox 45.0.1 following the STR from above, and wasn't able to reproduce at all.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 22 • 8 years ago

(In reply to Carsten Book [:Tomcat] from comment #20)
> (In reply to Carsten Book [:Tomcat] from comment #18)
> > https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54
> 
> dvander so this is the final patch that needs to land on beta and co ?

Yup.

	Carsten Book [:Tomcat]
	Comment 23 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/85a96d03d818

	Carsten Book [:Tomcat]
	Comment 24 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/6b7212e05883