Closed
Bug 1253691
Opened 8 years ago
Closed 8 years ago
issue-api-key.pl needs to take an app_id as well
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file)
625 bytes,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
The helper script used by the MozReview dev and test environments uses scripts/issue-api-key.pl to simulate a user having logged in via auth delegation. It currently takes a login and optional description. It should also take an optional app_id so we can use the MozReview-specific batch-attachment API.
Assignee | ||
Comment 1•8 years ago
|
||
So as discussed this is rather a specific approach, but it's the easiest: if the given description to issue-api-key.pl is "mozreview", then we set the stored mozreview app id. Otherwise we set no app_id, as before. This is much easier than requiring the MozReview test code to either calculate or look up the app_id each time we create an API key.
Attachment #8726877 -
Flags: review?(dylan)
Comment 2•8 years ago
|
||
Comment on attachment 8726877 [details] [diff] [review] Set app_id based on description Review of attachment 8726877 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8726877 -
Flags: review?(dylan) → review+
Assignee | ||
Comment 3•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 1bb2d45..f4f3505 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•