Closed
Bug 1252782
Opened 8 years ago
Closed 8 years ago
can't add a "See Also" to a Chromium bug on bugs.chromium.org
Categories
(bugzilla.mozilla.org :: General, defect, P2)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dkl)
Details
Attachments
(1 file, 1 obsolete file)
2.57 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
Since Chromium moved its bug tracking off of code.google.com, I can't add a Chromium Bug as a "See Also". In particular, if I add https://bugs.chromium.org/p/chromium/issues/detail?id=462142 as a "See Also" to bug 1252458, I get the error: ===== https://bugs.chromium.org/p/chromium/issues/detail?id=462142 is not a valid URL to a bug. See Also URLs should point to one of: show_bug.cgi in a Bugzilla installation. A bug on launchpad.net. An issue on code.google.com. A bug on bugs.debian.org. An issue in a JIRA installation. A ticket in a Trac installation. A bug in a MantisBT installation. A bug on sourceforge.net. An issue/pull request on github.com. A question on support.mozilla.org. An Aha feature on aha.io. An issue on webcompat.com. A request on ServiceNow. =====
Reporter | ||
Updated•8 years ago
|
Summary: can't add a "See Also" to a Chromium bug → can't add a "See Also" to a Chromium bug on bugs.chromium.org
Comment 1•8 years ago
|
||
glob, perhaps you know how to fix this? It'd be nice to get this fixed before too long -- it's very useful to be able to declaratively link our bugs to related Chrome bug reports.
Flags: needinfo?(glob)
(In reply to Daniel Holbert [:dholbert] from comment #1) > glob, perhaps you know how to fix this? It'd be nice to get this fixed > before too long -- it's very useful to be able to declaratively link our > bugs to related Chrome bug reports. https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/Bugzilla/BugUrl/Google.pm#L35 needs to be updated to support both domains.
Flags: needinfo?(glob)
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8732333 -
Flags: review?(dylan)
Assignee | ||
Comment 4•8 years ago
|
||
Updated license.
Attachment #8732333 -
Attachment is obsolete: true
Attachment #8732333 -
Flags: review?(dylan)
Attachment #8732341 -
Flags: review?(dylan)
Comment 5•8 years ago
|
||
Comment on attachment 8732341 [details] [diff] [review] 1252782_2.patch Review of attachment 8732341 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan ::: Bugzilla/BugUrl/Chromium.pm @@ +42,5 @@ > + if (!$bug_id) { > + ThrowUserError('bug_url_invalid', { url => $value, reason => 'id' }); > + } > + > + return new URI($value); possible nit: I think for new code we avoid using old-style constructors, right? fix on commit: URI->new($value);
Attachment #8732341 -
Flags: review?(dylan) → review+
Assignee | ||
Comment 6•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git d8e47b7..3af55bf master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•