Closed
Bug 1251498
Opened 8 years ago
Closed 8 years ago
Implement IDBKeyRange.includes()
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: khuey, Assigned: khuey)
References
()
Details
(Keywords: dev-doc-complete, Whiteboard: btpp-active)
Attachments
(1 file)
7.39 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Google is on board and its in the spec, so lets do it.
Attachment #8723910 -
Flags: review?(amarchesini)
Comment 1•8 years ago
|
||
Comment on attachment 8723910 [details] [diff] [review] Patch Review of attachment 8723910 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/IDBKeyRange.cpp @@ +340,5 @@ > + ErrorResult& aRv) const > +{ > + Key key; > + aRv = GetKeyFromJSVal(aCx, aValue, key); > + if (aRv.Failed()) { NS_WARN_IF ::: testing/web-platform/tests/IndexedDB/idbkeyrange-includes.htm @@ +3,5 @@ > +<title></title> > +<script src=/resources/testharness.js></script> > +<script src=/resources/testharnessreport.js></script> > +<script> > + extra spaces
Attachment #8723910 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #1) > Comment on attachment 8723910 [details] [diff] [review] > Patch > > Review of attachment 8723910 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/indexedDB/IDBKeyRange.cpp > @@ +340,5 @@ > > + ErrorResult& aRv) const > > +{ > > + Key key; > > + aRv = GetKeyFromJSVal(aCx, aValue, key); > > + if (aRv.Failed()) { > > NS_WARN_IF We don't do this anywhere else in this file, so I decided to ignore this.
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c0b66b8076e https://hg.mozilla.org/mozilla-central/rev/0d0247d97108
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment 6•8 years ago
|
||
I've documented includes(): https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange https://developer.mozilla.org/en-US/docs/Web/API/IDBKeyRange/includes And added a note to the relevant Firefox release notes: https://developer.mozilla.org/en-US/Firefox/Releases/47#IndexedDB A quick tech review would be great. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 7•8 years ago
|
||
lgtm, thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•