Closed
Bug 1245016
Opened 8 years ago
Closed 8 years ago
b2g build failure in gfx/layers/ipc/LayerAnimationUtils.h
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file, 1 obsolete file)
927 bytes,
patch
|
hiro
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → fabrice
Attachment #8714682 -
Flags: review?(hiikezoe)
Assignee | ||
Updated•8 years ago
|
Attachment #8714682 -
Flags: review?(hiikezoe)
Assignee | ||
Updated•8 years ago
|
Attachment #8714682 -
Attachment is obsolete: true
Comment 2•8 years ago
|
||
Fabrice, I am sorry for the breakage. I believe attachment #8714682 [details] [diff] [review] is correct. Why did you obsolete it?
Flags: needinfo?(fabrice)
Assignee | ||
Comment 3•8 years ago
|
||
Hiro, we were still missing the include for TimingFunction.
Flags: needinfo?(fabrice)
Attachment #8714692 -
Flags: review?(hiikezoe)
Comment 4•8 years ago
|
||
Comment on attachment 8714692 [details] [diff] [review] animationutils.patch v2 Can't we use forward declaration for the TimingFunction? And please remove the include line for Maybe.h in LayerAnimationUtils.cpp. Thanks.
Attachment #8714692 -
Flags: review?(hiikezoe) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/51bf027a5ceb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•