Jesse Ruderman Reporter
	Description • 8 years ago

https://github.com/MozillaSecurity/funfuzz/

funfuzz/dom/automation/domInteresting.py --background build m.html

Leaks nsDocument, nsGlobalWindow, etc.

(I'm guessing it has to be in the background to suppress the geolocation prompt and make it remain a pending request until shutdown?)

	Andrew McCreight [:mccr8]
	Comment 1 • 8 years ago

The behavior of geolocation in the background changed recently in bug 1216148, so perhaps that is related.

	Andrew McCreight [:mccr8]
	Comment 2 • 8 years ago

I also landed bug 1238427 on 1/22, which is more recent.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 3 • 8 years ago

Can you run the test case and see which patch (if either) introduced this?

	Ya-Chieh Wu (inactive)
	Comment 4 • 8 years ago

Hey Jesse Ruderman, 
before I start to test, I want to make sure that I don't misunderstand your point.

What you mean is that if a page starts in the background, gps is still working?
But you expect that this page shouldn't get updated?
  
Thanks!

	Kan-Ru Chen [:kanru] (UTC+9)
	Comment 5 • 8 years ago

(In reply to Ya-Chieh Wu from comment #4)
> Hey Jesse Ruderman, 
> before I start to test, I want to make sure that I don't misunderstand your
> point.
> 
> What you mean is that if a page starts in the background, gps is still
> working?
> But you expect that this page shouldn't get updated?
>   
> Thanks!

I think he means when a page starts and ends in the background, the pending request is leaked along with the document and window. Likely it's introduced by bug 1216148 because we stop the timer when page is in background. I think we should cleanup the requests when the window goes away instead of relying on the timeout timer.

	Ya-Chieh Wu (inactive)
	Comment 6 • 8 years ago

Hey Jesse,

I tried to reproduce the leak you mentioned but I passed with no leaks at all.
the message that funfuzz show: detect_leaks: PASS with no leaks at all 

I used your m.html and run with "funfuzz/dom/automation/domInteresting.py --background build m.html" 
I tried to click the share location button and not to share. Both cases close with no leaks.


Could you tell me what exactly your steps so I can try to reproduce.
many thanks!

	Jesse Ruderman Reporter
	Comment 7 • 8 years ago

I can still reproduce on trunk, as long as I leave the window unfocused. (When running with domInteresting.py, the testcase will instruct the browser to quit after a few seconds, so you shouldn't ever need to focus it.)

I wouldn't be surprised if this is Mac-specific.

	Ya-Chieh Wu (inactive)
	Comment 8 • 8 years ago

Hi Andrew,

Could you take a look at this? I think bug 1238427 could be related.

	Andrew McCreight [:mccr8]
	Comment 9 • 8 years ago

Sure.

	Andrew McCreight [:mccr8]
	Comment 10 • 8 years ago

I can reproduce on OSX.

The leaking nsGlobalWindow for the test case is being held alive via two missing references to the nsDocument for the test case. It isn't obvious to me how geo stuff can hold alive a document.

	Andrew McCreight [:mccr8]
	Comment 11 • 8 years ago

This does not seem to be a regression from bug 1240906.

	Andrew McCreight [:mccr8]
	Comment 12 • 8 years ago

This does not appear to be a regression from either bug 1238427 or bug 1216148. At least, I was able to back both of those out and the leak still occurred.

	Andrew McCreight [:mccr8]
	Comment 13 • 8 years ago

I don't think I'm going to have a chance to work on this soon. It doesn't seem like it was a regression from any recent work.