Closed
Bug 1243949
Opened 8 years ago
Closed 8 years ago
Failure to create a bloat log in a debug build should turn the tree orange
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
(Whiteboard: [MemShrink:P1])
Attachments
(1 file, 1 obsolete file)
894 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
As seen in bug 1219369, we aren't getting bloat logs for content processes on Windows mozilla-central. This means we aren't detecting leaks at all for these processes, without any indication of it on TreeHerder. The tree should turn orange if that happens. We should MOZ_ASSERT or something if InitLog fails. This could probably just be landed as part of bug 1219369, but I'll leave a separate bug for now. I think we do reconcile the pidlog against the processes we got a bloatlog from, so normally this would cause the tree to go orange, but I think we fail to write to the pidlog from the child process, for the same reason as bug 1219369. I'll file a separate bug for that.
Assignee | ||
Comment 1•8 years ago
|
||
try run showing that this detects the failure to create a leak log on Windows: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b76f140aaeb3 I'll look into this more once the Windows logging issue is fixed.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1242119 is needed for logs on WinXP. Linux 64 and Win7 try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5 WinXP and Win8 try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5 I should also grep through some logs for other platforms to see if they are failing to create logs.
Depends on: 1242119
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8715320 [details] [diff] [review] Fatally assert when we fail to create an XPCOM log. Oops, I already uploaded this patch.
Attachment #8715320 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8714577 [details] [diff] [review] Fatally assert when we fail to create an XPCOM log. Review of attachment 8714577 [details] [diff] [review]: ----------------------------------------------------------------- WinXP, Win7 and Linux64 look fine based on my try pushes. OSX seems fine from scanning a few logs. Android doesn't do leak checking at all (!?!?). B2G at least tries to, but I didn't see any evidence that it actually even attempts to create a bloat log, so hopefully that is okay. (This depends on a bunch of patches in the bugs it depends on to get leak logging working on Windows.)
Attachment #8714577 -
Flags: review?(nfroyd)
Comment 6•8 years ago
|
||
Comment on attachment 8714577 [details] [diff] [review] Fatally assert when we fail to create an XPCOM log. Review of attachment 8714577 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/base/nsTraceRefcnt.cpp @@ +705,5 @@ > aEnvVar, aMsg, fname.get()); > } else { > fprintf(stdout, "### %s defined -- unable to log %s to %s\n", > aEnvVar, aMsg, fname.get()); > + MOZ_ASSERT(false, "Tried and failed to create an XPCOM log"); This could optionally be MOZ_CRASH("Tried and failed...");
Attachment #8714577 -
Flags: review?(nfroyd) → review+
Updated•8 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P1]
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e94a21686360
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•