(no longer active) Assignee
	Description • 8 years ago

Firefox OS still needs to use the cache API both to access it, and possibly
store app:// URL resources inside it.  See for example code in
https://github.com/fxos-components/fxos-fastlist/blob/master/fxos-fastlist.js
that manipulates the cache.  Let's restore this support for now since it's
pretty harmless.

	(no longer active) Assignee
	Comment 2 • 8 years ago

This should help with at least part of the b2g breakage as a result of bug 1197379.

	Ben Kelly [:bkelly, not reviewing]
	Comment 3 • 8 years ago

Comment on attachment 8713299 [details] [diff] [review]
Restore support for accessing the Cache API from app:// URLs and also for storing requests/responses with app:// URLs within it

Review of attachment 8713299 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/fetch/app-protocol/index.html
@@ +15,5 @@
>    alert('DONE');
>  }
>  
>  function testFetchAppResource() {
> +  return fetch(location.href.replace('index.html', 'foo.txt')).then((res) => {

Not sure I understand this one.  Can you explain the test change?  Why isn't a relative URL ok?

	Hubert Figuiere [:hub]
	Comment 4 • 8 years ago

I tested the attached patch on my Flame and the app now behave properly. Without, I do get the security error about cache.

If the test run pass on try (I think there is another set of orange that currently happen because of another breakage - and they can be ignored for that run) this should be good. Ping me if you have questions about the test result of that try run.

Thanks !

	(no longer active) Assignee
	Comment 5 • 8 years ago

(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8713299 [details] [diff] [review]
> Restore support for accessing the Cache API from app:// URLs and also for
> storing requests/responses with app:// URLs within it
> 
> Review of attachment 8713299 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/tests/mochitest/fetch/app-protocol/index.html
> @@ +15,5 @@
> >    alert('DONE');
> >  }
> >  
> >  function testFetchAppResource() {
> > +  return fetch(location.href.replace('index.html', 'foo.txt')).then((res) => {
> 
> Not sure I understand this one.  Can you explain the test change?  Why isn't
> a relative URL ok?

Sorry, the test changes were unrelated, and not really supposed to be there in the patch!

	Pulsebot
	Comment 6 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ac111554d88

	(no longer active) Assignee
	Comment 7 • 8 years ago

(In reply to Hubert Figuiere [:hub] from comment #4)
> I tested the attached patch on my Flame and the app now behave properly.
> Without, I do get the security error about cache.
> 
> If the test run pass on try (I think there is another set of orange that
> currently happen because of another breakage - and they can be ignored for
> that run) this should be good. Ping me if you have questions about the test
> result of that try run.

Not sure which try run, since I didn't push this to try.  I just landed on inbound.

	Carsten Book [:Tomcat]
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3ac111554d88

	Adam Alldredge [:AdamA][Inactive]
	Comment 10 • 8 years ago

This issue is no longer occurring in Aries 2.6 and Flame 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20160201114120
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 4d224eb479016d230706363d36c415c2f4960e75
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Device: FlameKK 2.6 [Full Flash][512mb]
BuildID: 20160201030209
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 941033a51983ddec2d99aa9f868a54c0196a4075
Gonk: 8a066f7fa7410e32b58def35f322aa33f03db283
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Result:
user can see all lists in music app.