Closed Bug 1243077 Opened 8 years ago Closed 8 years ago

start implementing nsIAccessible for proxied accessibles

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla47

Tracking Flags:

Tracking

Status

firefox47

---

fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(17 files)

add AccessibleOrProxy::IsNull() 8 years ago Trevor Saunders (:tbsaunde) 1.55 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy::ChildCount() 8 years ago Trevor Saunders (:tbsaunde) 883 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy xpcAccessible::IntlGeneric() 8 years ago Trevor Saunders (:tbsaunde) 1.88 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
implement xpcAccessible::GetChildCount() for proxied accessibles 8 years ago Trevor Saunders (:tbsaunde) 875 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy::Role() 8 years ago Trevor Saunders (:tbsaunde) 1.32 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
make it possible to get MaiAtkObject::mAccWrap from an AtkObject* without casting to Accessible* or ProxyAccessible* 8 years ago Trevor Saunders (:tbsaunde) 1.69 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
add ToXPC{,Document} overloads for proxied accessibles 8 years ago Trevor Saunders (:tbsaunde) 2.58 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
simplify GetRoleCB some 8 years ago Trevor Saunders (:tbsaunde) 1.54 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
support proxied accessibles in xpcAccessible::GetRole() 8 years ago Trevor Saunders (:tbsaunde) 841 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy::ChildAt() 8 years ago Trevor Saunders (:tbsaunde) 879 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
make xpcAccessible::GetChildAt() work with proxied accessibles 8 years ago Trevor Saunders (:tbsaunde) 1.14 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
remove an unnecessary AddRef() from xpcAccessible::GetChildren() 8 years ago Trevor Saunders (:tbsaunde) 926 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
make xpcAccessible::GetChildren() work with proxied accessibles 8 years ago Trevor Saunders (:tbsaunde) 1.20 KB, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy::FirstChild() 8 years ago Trevor Saunders (:tbsaunde) 805 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
make xpcAccessible::GetFirstChild() work with proxies 8 years ago Trevor Saunders (:tbsaunde) 928 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
add AccessibleOrProxy::LastChild() 8 years ago Trevor Saunders (:tbsaunde) 796 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review
make xpcAccessible::GetLastChild() work with proxied accessibles 8 years ago Trevor Saunders (:tbsaunde) 891 bytes, patch	davidb : review+	Details \| Diff \| Splinter Review

Trevor Saunders (:tbsaunde)

Assignee

Description

•

8 years ago

      No description provided.

Trevor Saunders (:tbsaunde)

Assignee

Comment 1

•

8 years ago

Attached patch add AccessibleOrProxy::IsNull() — Details — Splinter Review

Attachment #8712296 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 2

•

8 years ago

Attached patch add AccessibleOrProxy::ChildCount() — Details — Splinter Review

Attachment #8712299 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 3

•

8 years ago

Attached patch add AccessibleOrProxy xpcAccessible::IntlGeneric() — Details — Splinter Review

It will be useful to get mIntl without casting it to either Accessible* or
  ProxyAccessible*.  saddly C++ won't let us overload the name Intl() this way
  so for now this method is named IntlGeneric().

Attachment #8712300 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 4

•

8 years ago

Attached patch implement xpcAccessible::GetChildCount() for proxied accessibles — Details — Splinter Review

Attachment #8712301 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 5

•

8 years ago

Attached patch add AccessibleOrProxy::Role() — Details — Splinter Review

Attachment #8712302 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 6

•

8 years ago

Attached patch make it possible to get MaiAtkObject::mAccWrap from an AtkObject* without casting to Accessible* or ProxyAccessible* — Details — Splinter Review

Attachment #8712303 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 7

•

8 years ago

Attached patch add ToXPC{,Document} overloads for proxied accessibles — Details — Splinter Review

Attachment #8712304 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 8

•

8 years ago

Attached patch simplify GetRoleCB some — Details — Splinter Review

We can replace the code  dealing with Accessibles and proxies differently with
a call to AccessibleOrProxy::Role()

Attachment #8712305 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 9

•

8 years ago

Attached patch support proxied accessibles in xpcAccessible::GetRole() — Details — Splinter Review

Attachment #8712306 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 10

•

8 years ago

Attached patch add AccessibleOrProxy::ChildAt() — Details — Splinter Review

Attachment #8712308 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 11

•

8 years ago

Attached patch make xpcAccessible::GetChildAt() work with proxied accessibles — Details — Splinter Review

Attachment #8712309 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 12

•

8 years ago

Attached patch remove an unnecessary AddRef() from xpcAccessible::GetChildren() — Details — Splinter Review

Attachment #8712310 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 13

•

8 years ago

Attached patch make xpcAccessible::GetChildren() work with proxied accessibles — Details — Splinter Review

Attachment #8712312 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 14

•

8 years ago

Attached patch add AccessibleOrProxy::FirstChild() — Details — Splinter Review

Attachment #8712313 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 15

•

8 years ago

Attached patch make xpcAccessible::GetFirstChild() work with proxies — Details — Splinter Review

Attachment #8712315 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 16

•

8 years ago

Attached patch add AccessibleOrProxy::LastChild() — Details — Splinter Review

Attachment #8712316 - Flags: review?(dbolter)

Trevor Saunders (:tbsaunde)

Assignee

Comment 17

•

8 years ago

Attached patch make xpcAccessible::GetLastChild() work with proxied accessibles — Details — Splinter Review

Attachment #8712317 - Flags: review?(dbolter)

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Assignee: nobody → tbsaunde+mozbugs

Blocks: e10sa11y2

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712296 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712299 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Comment 18

•

8 years ago

Comment on attachment 8712300 [details] [diff] [review]
add AccessibleOrProxy xpcAccessible::IntlGeneric()

Review of attachment 8712300 [details] [diff] [review]:
-----------------------------------------------------------------

nit: in commit message 'saddly' should be 'Sadly'

::: accessible/xpcom/xpcAccessibleGeneric.h
@@ +93,5 @@
>  
> +inline AccessibleOrProxy
> +xpcAccessible::IntlGeneric()
> +{
> +  return static_cast<xpcAccessibleGeneric*>(this)->mIntl;

I assume this static downcast is always safe?

Attachment #8712300 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712301 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712302 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712303 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Comment 19

•

8 years ago

Comment on attachment 8712304 [details] [diff] [review]
add ToXPC{,Document} overloads for proxied accessibles

Review of attachment 8712304 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/xpcom/xpcAccessibleDocument.cpp
@@ +17,1 @@
>  using namespace mozilla::a11y;

Why this change?

@@ +236,5 @@
> +    return nullptr;
> +  }
> +
> +  if (aAcc.IsAccessible()) {
> +    return ToXPC(aAcc.AsAccessible());

Took me a couple minutes to realize this is not recursive (calls the pointer version).

@@ +240,5 @@
> +    return ToXPC(aAcc.AsAccessible());
> +  }
> +
> + xpcAccessibleDocument* doc = ToXPCDocument(aAcc.AsProxy()->Document());
> + return doc->GetXPCAccessible(aAcc.AsProxy());

Maybe comment this case?

Attachment #8712304 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712305 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712306 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712308 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712309 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712310 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712312 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712313 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712315 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712316 - Flags: review?(dbolter) → review+

David Bolter [:davidb] (NeedInfo me for attention)

Updated

•

8 years ago

Attachment #8712317 - Flags: review?(dbolter) → review+

Trevor Saunders (:tbsaunde)

Assignee

Comment 20

•

8 years ago

> ::: accessible/xpcom/xpcAccessibleDocument.cpp
> @@ +17,1 @@
> >  using namespace mozilla::a11y;
> 
> Why this change?

so a11y::ToXPC() is resolved correctly.

> @@ +240,5 @@
> > +    return ToXPC(aAcc.AsAccessible());
> > +  }
> > +
> > + xpcAccessibleDocument* doc = ToXPCDocument(aAcc.AsProxy()->Document());
> > + return doc->GetXPCAccessible(aAcc.AsProxy());
> 
> Maybe comment this case?

what about it?

David Bolter [:davidb] (NeedInfo me for attention)

Comment 21

•

8 years ago

(In reply to Trevor Saunders (:tbsaunde) from comment #20)
> > ::: accessible/xpcom/xpcAccessibleDocument.cpp
> > @@ +17,1 @@
> > >  using namespace mozilla::a11y;
> > 
> > Why this change?
> 
> so a11y::ToXPC() is resolved correctly.

OK!

> 
> > @@ +240,5 @@
> > > +    return ToXPC(aAcc.AsAccessible());
> > > +  }
> > > +
> > > + xpcAccessibleDocument* doc = ToXPCDocument(aAcc.AsProxy()->Document());
> > > + return doc->GetXPCAccessible(aAcc.AsProxy());
> > 
> > Maybe comment this case?
> 
> what about it?

What it is for/does, but note it was just a 'maybe'.

Pulsebot

Comment 22

•

8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a07577f0aefd
https://hg.mozilla.org/integration/mozilla-inbound/rev/804f5ebbce32
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbf99ea0009f
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fbe4c374125
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa8b790a065
https://hg.mozilla.org/integration/mozilla-inbound/rev/d599cfd59bae
https://hg.mozilla.org/integration/mozilla-inbound/rev/c32e7fc59790
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd9f45122aac
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0dcb76915b
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a3ee73a18b
https://hg.mozilla.org/integration/mozilla-inbound/rev/1043ed1709e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/98893db2e359
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eace7d4ac0c
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4fd3a5a6e47
https://hg.mozilla.org/integration/mozilla-inbound/rev/d64cb3fcfea6
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a5821c0595e
https://hg.mozilla.org/integration/mozilla-inbound/rev/70012ce32c86

Carsten Book [:Tomcat]

Comment 23

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a07577f0aefd
https://hg.mozilla.org/mozilla-central/rev/804f5ebbce32
https://hg.mozilla.org/mozilla-central/rev/dbf99ea0009f
https://hg.mozilla.org/mozilla-central/rev/1fbe4c374125
https://hg.mozilla.org/mozilla-central/rev/8fa8b790a065
https://hg.mozilla.org/mozilla-central/rev/d599cfd59bae
https://hg.mozilla.org/mozilla-central/rev/c32e7fc59790
https://hg.mozilla.org/mozilla-central/rev/fd9f45122aac
https://hg.mozilla.org/mozilla-central/rev/bb0dcb76915b
https://hg.mozilla.org/mozilla-central/rev/a6a3ee73a18b
https://hg.mozilla.org/mozilla-central/rev/1043ed1709e5
https://hg.mozilla.org/mozilla-central/rev/98893db2e359
https://hg.mozilla.org/mozilla-central/rev/7eace7d4ac0c
https://hg.mozilla.org/mozilla-central/rev/f4fd3a5a6e47
https://hg.mozilla.org/mozilla-central/rev/d64cb3fcfea6
https://hg.mozilla.org/mozilla-central/rev/8a5821c0595e
https://hg.mozilla.org/mozilla-central/rev/70012ce32c86

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox47: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla47

Carsten Book [:Tomcat]

Comment 24

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a07577f0aefd
https://hg.mozilla.org/mozilla-central/rev/804f5ebbce32
https://hg.mozilla.org/mozilla-central/rev/dbf99ea0009f
https://hg.mozilla.org/mozilla-central/rev/1fbe4c374125
https://hg.mozilla.org/mozilla-central/rev/8fa8b790a065
https://hg.mozilla.org/mozilla-central/rev/d599cfd59bae
https://hg.mozilla.org/mozilla-central/rev/c32e7fc59790
https://hg.mozilla.org/mozilla-central/rev/fd9f45122aac
https://hg.mozilla.org/mozilla-central/rev/bb0dcb76915b
https://hg.mozilla.org/mozilla-central/rev/a6a3ee73a18b
https://hg.mozilla.org/mozilla-central/rev/1043ed1709e5
https://hg.mozilla.org/mozilla-central/rev/98893db2e359
https://hg.mozilla.org/mozilla-central/rev/7eace7d4ac0c
https://hg.mozilla.org/mozilla-central/rev/f4fd3a5a6e47
https://hg.mozilla.org/mozilla-central/rev/d64cb3fcfea6
https://hg.mozilla.org/mozilla-central/rev/8a5821c0595e
https://hg.mozilla.org/mozilla-central/rev/70012ce32c86

You need to log in before you can comment on or make changes to this bug.