Closed
Bug 1238213
Opened 8 years ago
Closed 8 years ago
Make FetchEvent.request non-nullable
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
8.09 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
It seems that the spec has changed now to make |request| a required init member, so it is non-nullable now.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8705931 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 2•8 years ago
|
||
Comment on attachment 8705931 [details] [diff] [review] Make FetchEvent.request non-nullable Review of attachment 8705931 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/webidl/FetchEvent.webidl @@ +10,5 @@ > [Constructor(DOMString type, optional FetchEventInit eventInitDict), > Func="mozilla::dom::workers::ServiceWorkerVisible", > Exposed=(ServiceWorker)] > interface FetchEvent : ExtendableEvent { > + [SameObject] readonly attribute Request request; Do we still need [SameObject] ? ::: dom/workers/test/serviceworkers/fetch_event_worker.js @@ +297,5 @@ > + try { > + new FetchEvent("foo"); > + } catch(e) { > + if (e.name == "TypeError") { > + dump("XXXehsan " + e + "\n" + e.name + "\n"); dump?
Attachment #8705931 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #2) > Comment on attachment 8705931 [details] [diff] [review] > Make FetchEvent.request non-nullable > > Review of attachment 8705931 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/webidl/FetchEvent.webidl > @@ +10,5 @@ > > [Constructor(DOMString type, optional FetchEventInit eventInitDict), > > Func="mozilla::dom::workers::ServiceWorkerVisible", > > Exposed=(ServiceWorker)] > > interface FetchEvent : ExtendableEvent { > > + [SameObject] readonly attribute Request request; > > Do we still need [SameObject] ? Yes.
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f372ff2c6518 https://hg.mozilla.org/mozilla-central/rev/3bbaa0504a64
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 7•8 years ago
|
||
I've added a note about this to the request doc: https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/request And a note to the Gecko 46 release notes: https://developer.mozilla.org/en-US/Firefox/Releases/46#Service_Workers Let me know if this is ok.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•