Closed
Bug 1237326
Opened 8 years ago
Closed 8 years ago
Apache2::Log should only be loaded if we're running under mod_perl
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: reznord, Mentored)
Details
Attachments
(1 file)
|
573 bytes,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
BMO only runs under mod_perl, but devs use CGI frequently (because There Can Be Only One mod_perl instance). If you don't have mod_perl installed, "use Apache2::Log" will cause an error. This should be fixed, possibly by changing the "use Apache2::Log" line into a "require Apache2::Log" and moving it into _log_it() in extensions/Push/lib/Logger.pm?
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → allamsetty.anup
|
|
Assignee | |
Comment 1•8 years ago
|
||
Made the changes as requested in the comment 0.
Attachment #8704715 -
Flags: review?(dylan)
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8704715 [details] [diff] [review] changed "use Apache2::Log" line into a "require Apache2::Log" Review of attachment 8704715 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8704715 -
Flags: review?(dylan) → review+
|
|
Reporter | |
Comment 3•8 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git 9a15297..08931ab master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Extensions: Push → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•