Closed
Bug 1235073
Opened 8 years ago
Closed 8 years ago
support fallback when incoming query fails whitelist check
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), defect)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
41 bytes,
text/x-github-pull-request
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Review |
Right now, if an update query fails a rule's whitelist check, no more rules are processed and it gets no update at all. This sucks, because it means we can't have any sort of fallback for non-whitelisted users.
Attachment #8701854 -
Flags: review?(catlee)
Assignee | ||
Comment 1•8 years ago
|
||
Comment on attachment 8701854 [details] [review] make whitelisting work like other rule matching Got r+ in PR. Will do final verification on aus4-dev before pushing to production.
Attachment #8701854 -
Flags: review?(catlee)
Attachment #8701854 -
Flags: review+
Attachment #8701854 -
Flags: checked-in+
Assignee | ||
Comment 2•8 years ago
|
||
Verified in dev this morning, and pushed to prod.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•8 years ago
|
||
This didn't end up going live until today...I somehow managed only to push to aus4-admin when I originally pushed live. It's since been fixed, and verified to be working in production.
Comment 4•8 years ago
|
||
This issue is verified fixed. A user with a non-whitelisted device will properly receive an OTA update on the 'dogfood' and 'dogfood-test' channels, while a whitelisted device will receive the full FOTA update. When updating from the 20151023103433 watershed build on the 'dogfood' channel, a non-whitelisted device will perform an OTA to this build: Environmental Variables: Device: Aries 2.6 BuildID: 20151230203751 Gaia: f3cf488a97ecaec43369f3e3d8a7dda52be019f9 Gecko: ff1d0474af716e9108b386c863d799cf4916cd67 Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 46.0a1 (2.6) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0 A whitelisted device will perform a FOTA to this build: Environmental Variables: Device: Aries 2.6 BuildID: 20151230211515 Gaia: f3cf488a97ecaec43369f3e3d8a7dda52be019f9 Gecko: ff1d0474af716e9108b386c863d799cf4916cd67 Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56 Version: 46.0a1 (2.6) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0 Note: The whitelisted device has updated to the new gonk, whereas the non-whitelisted device has remained on the previous gonk.
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•