Closed
Bug 1234700
Opened 9 years ago
Closed 8 years ago
Hide window.showModalDialog, at least when e10s is enabled
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: emk, Assigned: emk)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
7.33 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
The broken feature is worse than no feature because the former will hinder feature detection. This is not a theoretical possibility. The broken showModalDialog breaks at least Office 365 and Exchange 2013. See bug 1077002 comment #13 and onwards.
Updated•9 years ago
|
Keywords: dev-doc-needed,
site-compat
Assignee | ||
Updated•9 years ago
|
tracking-e10s:
--- → ?
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d21b68c0775f
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e247bc83b16f
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3477c107fabc
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73e1ccc19b2d
Assignee | ||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
lgtm, fwiw
Updated•8 years ago
|
Attachment #8701376 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b9b9c8d4207d31b9de8adb21404bb9a584485b5 Bug 1234700 - Hide window.showModalDialog when e10s is enabled. r=jimm
Updated•8 years ago
|
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b9b9c8d4207
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 9•8 years ago
|
||
Posted the site compat doc: https://www.fxsitecompat.com/en-US/docs/2015/showmodaldialog-has-been-disabled-in-multi-process-firefox/
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to Kohei Yoshino [:kohei] from comment #9) > Posted the site compat doc: > https://www.fxsitecompat.com/en-US/docs/2015/showmodaldialog-has-been-disabled-in-multi-process-firefox/ > showModalDialog has been disabled in multi-process Firefox I think the term "disable" is obscure here. Prior to Firefox 39, showModalDialog always threw NS_ERROR_UNEXPECTED in e10s. Firefox 39 changed the logic to check e10s explicitly and throw NS_ERROR_NOT_AVAILABLE if in e10s. This bug removed showModalDialog itself from the window object, but showModalDialog was already "disabled" in e10s. > At least Office 365 and Exchange 2016 are known to be broken due to the missing showModalDialog. They are broken due to present-but-unworking showModalDialog. They will work if showModalDialog is missing because they use feature detection. This bug will *fix* them in e10s.
Comment 11•8 years ago
|
||
As this is not the default, I have added a comment in https://developer.mozilla.org/en-US/Firefox/Releases/46#DOM_HTML_DOM only
Keywords: dev-doc-needed → dev-doc-complete
Comment 12•8 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #10) > (In reply to Kohei Yoshino [:kohei] from comment #9) > I think the term "disable" is obscure here. Prior to Firefox 39, > showModalDialog always threw NS_ERROR_UNEXPECTED in e10s. Firefox 39 changed > the logic to check e10s explicitly and throw NS_ERROR_NOT_AVAILABLE if in > e10s. This bug removed showModalDialog itself from the window object, but > showModalDialog was already "disabled" in e10s. Thanks for your clarification. I'm adding the details to the doc. The title may be okay if explained well.
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•