Martin Shuman [:Marty] Reporter
	Description • 9 years ago

Description:
When the user starts recording a video, the camera viewfinder will freeze. This viewfinder will stay frozen until the user navigates away from the camera viewfinder (preview mode, homescreen, lock device).

Videos will still be recorded properly, but the user will not have the viewfinder to frame their video properly.

Repro Steps:
1) Update a Aries to 20151214121335
2) Open the Camera app. Switch to Video mode.
3) Begin recording the video.

Actual:
Video viewfinder will freeze when starting the video, and remain frozen after the recording has completed.

Expected:
Video viewfinder remains functional when starting and after recording a video.

Environmental Variables:
Device: Aries 2.6
Build ID: 20151214121335
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: 99137d6d4061f408ae0869122649d8bdf489cc30
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 5/5
Link to failed test case: https://moztrap.mozilla.org/manage/case/2477/
See attached: Video (URL), Logcat

	Martin Shuman [:Marty] Reporter
	Comment 1 • 9 years ago

This issue DOES occur on the latest Flame 2.6 build.
Video viewfinder will freeze when starting the video, and remain frozen after the recording has completed.

Environmental Variables:
Device: FlameKK 2.6 (512MB)
BuildID: 20151214030209
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: 99137d6d4061f408ae0869122649d8bdf489cc30
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

*******************************************

This issue does NOT occur on the latest Flame 2.5 build.
Video viewfinder remains functional when starting and after recording a video.

Environmental Variables:
Device: FlameKK 2.5 (512MB)
BuildID: 20151214083757
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: d76a9f65b6ba2ab587d3a0fb5119773ba68720a0
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

	Pi Wei Cheng [:piwei] (inactive)
	Comment 2 • 9 years ago

mozilla inbound regression window:

Last Working
Device: Flame 2.6
BuildID: 20151211074133
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: ee132b90ad4b11b03c4dcc5b21bc636ef11bbe66
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

First Broken
Device: Flame 2.6
BuildID: 20151211081830
Gaia: d886e152b42e557db612470d3417fe2947cbdeee
Gecko: eb3d458624eb3a62e8aebfaed322a63314153d3e
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Gaia is the same so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ee132b90ad4b11b03c4dcc5b21bc636ef11bbe66&tochange=eb3d458624eb3a62e8aebfaed322a63314153d3e

Caused by changes made in Bug 1214148.

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 3 • 9 years ago

Andrea this issue seems to have been caused by the changes for bug 1214148.  Can you please take a look?

	Martin Shuman [:Marty] Reporter
	Comment 4 • 9 years ago

This appears to have been fixed with the fixes for bug 1232363.

	Martin Shuman [:Marty] Reporter
	Comment 5 • 9 years ago

This issue is verified fixed on the latest Aries and Flame 2.6 builds.
Video viewfinder remains functional when starting and after recording a video.

Environmental Variables:
Device: Aries 2.6
BuildID: 20151215145647
Gaia: ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gecko: cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Environmental Variables:
Device: FlameKK 2.6 (512MB)
BuildID: 20151215145230
Gaia: ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gecko: cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

	Alastor Wu [:alwu] Assignee
	Comment 6 • 9 years ago

Already find the possible solution, I'm testing the patch now.

	Alastor Wu [:alwu] Assignee
	Comment 9 • 9 years ago

This changeset is based on the bug1214148.

---

Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1385b96f0866

	Alastor Wu [:alwu] Assignee
	Comment 11 • 9 years ago

New try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a370af00adc5

	Alastor Wu [:alwu] Assignee
	Comment 12 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3722faff75b2

	Alastor Wu [:alwu] Assignee
	Comment 13 • 9 years ago

Review commit: https://reviewboard.mozilla.org/r/28759/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28759/

	Alastor Wu [:alwu] Assignee
	Comment 14 • 9 years ago

Hi, Baku,
Could you help me review this patch?
Very appreciate!

---

This issue is caused by our nest-frame checking error.

Since the normal OOP processes are opened out from b2g process, the owner of their tabParent are the same - system app window. Therefore, in order to find the real case of nested MozFrame, we need to exclude this situation.

	Andrea Marchesini [:baku]
	Comment 15 • 9 years ago

Comment on attachment 8700562 [details]
MozReview Request: Bug 1232348 - adjust nested-frame checking condition. r=baku.

https://reviewboard.mozilla.org/r/28759/#review25519

::: dom/browser-element/BrowserElementAudioChannel.cpp:583
(Diff revision 1)
> -    if (!iTabParent) {
> +    nsresult rv = IsFromNestedFrame(aSubject, isNested);

if (NS_WARN_IF(NS_FAILED(rv))) {
  return rv;
}

::: dom/browser-element/BrowserElementAudioChannel.cpp:588
(Diff revision 1)
> -    return NS_OK;
> +    return rv;

keep return NS_OK

::: dom/browser-element/BrowserElementAudioChannel.cpp:661
(Diff revision 1)
> +{

aIsNested = false;

::: dom/browser-element/BrowserElementAudioChannel.cpp:664
(Diff revision 1)
> +    aIsNested = false;

remove all of these.

::: dom/browser-element/BrowserElementAudioChannel.cpp:685
(Diff revision 1)
> +    aIsNested = true;

and keep only this

We should land this with all the other patches. Is this the only blocker we have, or do we have other regressions?

	Alastor Wu [:alwu] Assignee
	Comment 16 • 9 years ago

(In reply to Andrea Marchesini (:baku) from comment #15)
> We should land this with all the other patches. Is this the only blocker we
> have, or do we have other regressions?

Thanks for review :)

I think the bug-landing order should be like following,
> bug1232363 -> bug1214148 -> bug1232348 (this bug)

	Alastor Wu [:alwu] Assignee
	Comment 17 • 9 years ago

Comment on attachment 8700562 [details]
MozReview Request: Bug 1232348 - adjust nested-frame checking condition. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28759/diff/1-2/

	Adam Alldredge [:AdamA][Inactive]
	Comment 18 • 9 years ago

We are seeing this issue occurring again on the latest Aries 2.6 and Flame 2.6 builds. The behaviour of bug 1232399 which was duped to this one is also occurring again on Flame 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20151223122247
Gaia: 94cc99aac11339e297da186ec7153ca4ae9ab8cd
Gecko: 35b211eaad1fa828064514c547057e4400e24459
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Environmental Variables:
Device: FlameKK 2.6 [Full Flash][512mb]
BuildID: 20151223030206
Gaia: 94cc99aac11339e297da186ec7153ca4ae9ab8cd
Gecko: 35b211eaad1fa828064514c547057e4400e24459
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Result:
The viewfinder freezes when a video is being recorded on both devices and videos keep pausing on Flame.

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 19 • 9 years ago

This was not occurringd until today even those this bug was reopened on the 17. I suspect that the check-in bug 1232363 might have introduced this again. QA Wanted to determine if this is the case.

	Pi Wei Cheng [:piwei] (inactive)
	Comment 20 • 9 years ago

I'm pretty sure the re-land of bug 1214148 caused this bug to re-occur, and we already have a patch on this bug and we just need to land the fix on this side ASAP. See comment 16.

	Pulsebot
	Comment 21 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0de6c39787f1

	Ryan VanderMeulen [:RyanVM]
	Comment 22 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/0de6c39787f1

	Tony(Leave from Mozilla)
	Comment 23 • 8 years ago

  This bug has been verified as "pass" on the latest build of Flame KK master user and Aries KK master user by the STR in comment 0.

Actual results: Video viewfinder remains functional when starting and after recording a video.
See attachment: verified_Aries KK_master.3gp.
Reproduce rate: 0/10


Device: Flame KK master user 512mb(Pass)
Build ID               20151226150205
Gaia Revision          adf75f7a97ea0627b3211f0eef61eb72073f2dff
Gaia Date              2015-12-24 10:09:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c39a71cf41460924d2988d2d63be2f5d267db82a
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151226.191358
Firmware Date          Sat Dec 26 19:14:11 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master user(Pass)
Build ID               20151226120538
Gaia Revision          adf75f7a97ea0627b3211f0eef61eb72073f2dff
Gaia Date              2015-12-24 10:09:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c39a71cf41460924d2988d2d63be2f5d267db82a
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151226.123550
Firmware Date          Sat Dec 26 12:35:58 UTC 2015
Bootloader             s1

	u535950
	Comment 25 • 8 years ago

Hello,

This bug is also reproducible on ZTE Open C v2.5. The STR are the same as described in Comment 0.

After adapting the patch for 2.5, applied it, builded and flashed gecko, the bug has gone. Moreover, it resolved another bug I was encountering : Unable to hear sound when going to Settings > Ringtones/Alert and tapping on a ringtone or an alert.

	Alastor Wu [:alwu] Assignee
	Comment 26 • 8 years ago

I think you can merge this bug and bug1232363 back to v2.5 :)

	u535950
	Comment 27 • 8 years ago

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1214148
User impact if declined: Video Mode will freeze, when user start video recording.
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

	u535950
	Comment 28 • 8 years ago

Hello,

What should I do now, to make the patch applied into v2.5 branch ?

	u535950
	Comment 29 • 8 years ago

Hello,

Can you verify and apply the patch (attachment 8719918 [details] [diff] [review]) please ?

Thank you in advance.

	Alastor Wu [:alwu] Assignee
	Comment 30 • 8 years ago

Hi, micgeri, 
I don't have a permission to check-in code to v2.5 branch.

---

Hi, Josh,
Could you help to check-in this patch?
Thanks!

	Josh Cheng [:josh]
	Comment 31 • 8 years ago

Hi Mahe,
Do we still land patch for smartphone in 2.5?

	Mahendra Potharaju [:mahe]
	Comment 32 • 8 years ago

Hey Josh, 

No, we need not land any patch on 2.5 for smartphone. 

Only fixes for the TV, as you deem fit. 

Thanks

	:gerard-majax
	Comment 33 • 8 years ago

(In reply to Mahendra Potharaju [:mahe] from comment #32)
> Hey Josh, 
> 
> No, we need not land any patch on 2.5 for smartphone. 
> 
> Only fixes for the TV, as you deem fit. 
> 
> Thanks

I understand the situation, but micgeri is an external contributor, and he asked for the uplift way before the decision regarding for smartphone. Uplifting this will unblock contributors on smartphones, which is really important in the context of the transition work.

	Mahendra Potharaju [:mahe]
	Comment 34 • 8 years ago

We do not have any sheriff support any longer. And I don't think we are making builds off 2.5. 

Should this instead go into the new repos kanikani/pine?

	:gerard-majax
	Comment 35 • 8 years ago

(In reply to Mahendra Potharaju [:mahe] from comment #34)
> We do not have any sheriff support any longer. And I don't think we are
> making builds off 2.5. 

But contributors are doing them.

> 
> Should this instead go into the new repos kanikani/pine?

No.

	Josh Cheng [:josh]
	Comment 36 • 8 years ago

Comment on attachment 8719918 [details] [diff] [review]
Adjust nested frame checking (adapted for v2.5 branch)

Approve for b2g44 as this is a small patch which could benefit our contributor.

	Josh Cheng [:josh]
	Comment 37 • 8 years ago

Hi Gary, 
Could you help to merge this patch to 2.5 Gecko? Thanks

	Gary Chen [:xeonchen]
	Comment 38 • 8 years ago

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4394647bdf0d