Closed Bug 1225214 Opened 9 years ago Closed 8 years ago

Implement very simple request time logging

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dylan)

Details

Attachments

(1 file, 2 obsolete files)

- store start_time in the request_cache at the start of a request (init_page should do)
- at the end of the request, syslog the time information out as "$request_url " . (time - $request_cache->{start_time})
- use this data when there are huge spikes in the webheads load graphs to figure out what's the worst requests.
Summary: Implement very simple request timing logging → Implement very simple request time logging
Attached patch 1225214_1.patch (obsolete) — Splinter Review
note: this is deployed to bugzilla-dev for additional testing. If you think it's safe I'd love for it to go out this week... of course we can always wait, but getting more data on request times would be good.
Attachment #8688096 - Flags: review?(dkl)
Attached patch 1225214_3.patch (obsolete) — Splinter Review
It seems like I can't rely on the info from $cgi during _cleanup, but the envs are still good (this is only under bugzilla-dev's mod_perl, it seemed to work locally). Also no logging except under mod_perl.
Attachment #8688096 - Attachment is obsolete: true
Attachment #8688096 - Flags: review?(dkl)
Attachment #8688114 - Flags: review?(dkl)
Comment on attachment 8688114 [details] [diff] [review]
1225214_3.patch

Review of attachment 8688114 [details] [diff] [review]:
-----------------------------------------------------------------

Never mind, as usual with bugzilla this will require a little more thought.
Attachment #8688114 - Flags: review?(dkl)
Attached patch 1225214_2.patchSplinter Review
Finally got around to doing this right.
Attachment #8688114 - Attachment is obsolete: true
Attachment #8739150 - Flags: review?(dkl)
Comment on attachment 8739150 [details] [diff] [review]
1225214_2.patch

Review of attachment 8739150 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8739150 - Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   dacce0f..f885e90  master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: