Verson Xiong (Leave from Mozilla) Reporter
	Description • 9 years ago

[1.Description]:
[Arieskk v2.5&v2.6][Flamekk v2.5&v2.6][Browser]Window manager's background color or new window button's color should be changed,if button's color is same as the background color it will result in that user is hard to find new window button.
Found time:17:23
See attachment:logcat_1723.txt & AriesKK_video.3gp

[2.Testing Steps]: 
1. Open browser app.
2. Open browser's window manager.
3. Observe the view.

[3.Expected Result]: 
3. User can find new window button easily.

[4.Actual Result]: 
3. User can't find buttons because button's color is same as the background color.

[5.Reproduction build]: 
Device: Aries KK v2.6 master( Affected )
Build ID               20151112014800
Gaia Revision          fdb66f75963fa9255f707af87f405d54892e5e7d
Gaia Date              2015-11-11 17:17:32
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ed7dd831d1969a5a1a8636e63bd93d6aeaf94a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.011957
Firmware Date          Thu Nov 12 01:20:05 UTC 2015
Bootloader             s1

Device: Aries KK v2.5( Affected )
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 master 512mb( Affected )
Build ID               20151111150236
Gaia Revision          22f8023b112dfae83531b0a075ab9eb9a5444dfa
Gaia Date              2015-11-10 23:35:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151111.182640
Firmware Date          Wed Nov 11 18:26:52 EST 2015
Bootloader             L1TC000118D0

Device: Flame KK v2.5  512mb( Affected )
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

	Gregor Wagner [:gwagner]
	Comment 2 • 9 years ago

What should we change here?

	Tiffanie Shakespeare [:tif]
	Comment 3 • 9 years ago

Passing to Eric to take a look at. 

Eric, the background of the window manager is white, which is the same color as the new window icon (as seen in task manager).

Thanks for pinging the UX team!

	Norry.L.F(Leave from Mozilla)
	Comment 5 • 9 years ago

[Blocking Requested - why for this release]: Obviously affect new user. These new users maybe even don't know these two icons on the left/right-bottom corner on browser's window manager screen.

	Gregor Wagner [:gwagner]
	Comment 6 • 9 years ago

Eric?

	Gregor Wagner [:gwagner]
	Comment 7 • 9 years ago

Too late to fix it for 2.5 but lets fix it for 2.6.

	Michael Henretty [:mikehenrty][:mhenretty]
	Comment 8 • 8 years ago

Tilman is going to take this one.

	Michael Henretty [:mikehenrty][:mhenretty]
	Comment 10 • 8 years ago

Comment on attachment 8704084 [details] [review]
[gaia] tilmankamp:fix-1224138 > mozilla-b2g:master

much improved!

	u520299 Assignee
	Comment 11 • 8 years ago

Here is a screenshot of the fix.

	u520299 Assignee
	Comment 13 • 8 years ago

This is how the buttons look in the provided fix. Ignore the last shot, as this was just a counter test - ensuring that the global card view still looks the same.

	Eric Pang [:epang] UX
	Comment 14 • 8 years ago

Comment on attachment 8704084 [details] [review]
[gaia] tilmankamp:fix-1224138 > mozilla-b2g:master

R+ Thanks for the patch Tilman!

	u520299 Assignee
	Comment 15 • 8 years ago

Merged into master
https://github.com/mozilla-b2g/gaia/commit/5ad4752a041f327952f9b693c8b9e95249e48acb

	Gregor Wagner [:gwagner]
	Comment 16 • 8 years ago

(In reply to Tilman Kamp [:tilman] from comment #15)
> Merged into master
> https://github.com/mozilla-b2g/gaia/commit/
> 5ad4752a041f327952f9b693c8b9e95249e48acb

\o/

	Adam Alldredge [:AdamA][Inactive]
	Comment 17 • 8 years ago

This issue is verified fixed on Flame 2.6 and Aries 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20160107105120
Gaia: 676237f80cf72182500356fabc49365d3471c0e6
Gecko: e0bcd16e1d4b99ba3e542149d0d41e0f60c54b5c
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Device: FlameKK 2.6 [Full Flash][512mb]
BuildID: 20160107030227
Gaia: 676237f80cf72182500356fabc49365d3471c0e6
Gecko: e0bcd16e1d4b99ba3e542149d0d41e0f60c54b5c
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Result:
the buttons are visible in the browser show windows.
---------------------------------------
This issue DOES OCCUR on flame 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20160107105232
Gaia: ecda2cb4850b03a1d5fde8b91f359a3ece0a0764
Gecko: 26cb061052c8059fd5021c81bb032de551e3efc2
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
User can't find buttons because button's color is same as the background color.