Ben Gaskin Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (Linux; Android 5.0.2; 404SC Build/LRX22G) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.76 Mobile Safari/537.36

Steps to reproduce:

Tried to login to bugzilla, didn't have an existing account.
Chose to login via github.


Actual results:

I was promoted for user name and password and notified on screen that a new bugzilla account was being created. Then I was just returned to the login screen (still not logged on).


Expected results:

I should have been logged on or been given a prompt to create a bugzilla password.


Eventually I created my login without using github.

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 1 • 9 years ago

This appears to be a regression caused by 2fa. 

Does logging in with github work now that the account is created?

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 2 • 9 years ago

Looks like it may be related to a CSRF protection (cookie/state not matching)

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 3 • 9 years ago

This was a silly bug. Basically we need to check for a code param or an email param in a GET request. We're just checking for a code one now, which breaks when someone has multiple github accounts.

	Ben Gaskin Reporter
	Comment 4 • 9 years ago

(In reply to Dylan William Hardison [:dylan] from comment #1)
> This appears to be a regression caused by 2fa. 
> 
> Does logging in with github work now that the account is created?

Yes, that works.  As you say, now that I have my bugzilla account created I can log in via github.

	Ben Gaskin Reporter
	Comment 5 • 9 years ago

(In reply to Dylan William Hardison [:dylan] from comment #1)
> This appears to be a regression caused by 2fa. 
> 
> Does logging in with github work now that the account is created?

Yes, that works.  As you say, now that I have my bugzilla account created I can log in via github.

	Ben Gaskin Reporter
	Comment 6 • 9 years ago

(In reply to Dylan William Hardison [:dylan] from comment #1)
> This appears to be a regression caused by 2fa. 
> 
> Does logging in with github work now that the account is created?

Yes, that works.  As you say, now that I have my bugzilla account created I can log in via github.

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 7 • 9 years ago

(In reply to Ben Gaskin from comment #6)
> (In reply to Dylan William Hardison [:dylan] from comment #1)
> > This appears to be a regression caused by 2fa. 
> > 
> > Does logging in with github work now that the account is created?
> 
> Yes, that works.  As you say, now that I have my bugzilla account created I
> can log in via github.

Figured as much. Thanks for the bug report!

	David Lawrence [:dkl]
	Comment 8 • 9 years ago

Comment on attachment 8685712 [details] [diff] [review]
1223590_1.patch

Review of attachment 8685712 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 9 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   2c3a839..090abc7  master -> master