Closed
Bug 1223421
Opened 9 years ago
Closed 8 years ago
Hide/Obfuscate MozReview API Keys
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file, 1 obsolete file)
2.15 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
To avoid confusion, mozreview api keys should be readily usable on the api keys page.
Assignee | ||
Comment 1•8 years ago
|
||
Sigh. Comment #0 should say: To avoid confusion, mozreview api keys should NOT be readily usable on the api keys page
this has cropped up a few times over the last week causing much confusion, so here's a quick-n-dirty fix.
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8722333 [details] [diff] [review] 1223421_1.patch Review of attachment 8722333 [details] [diff] [review]: ----------------------------------------------------------------- Shouldn't rely on the description for this, I think. I have a fixed patch which I'll ask you to review :-)
Attachment #8722333 -
Flags: review?(dylan) → review-
Assignee | ||
Comment 4•8 years ago
|
||
Same as before except is_mozreview logic in the APIKey class.
Assignee: glob → dylan
Attachment #8722333 -
Attachment is obsolete: true
Attachment #8722534 -
Flags: review?(glob)
Comment on attachment 8722534 [details] [diff] [review] 1223421_2.patch Review of attachment 8722534 [details] [diff] [review]: ----------------------------------------------------------------- much better; r=glob ::: template/en/default/account/prefs/apikey.html.tmpl @@ +46,5 @@ > + [% END %] > + </td> > + <td> > + [% IF api_key.is_mozreview %] > + [% api_key.description FILTER html %] perhaps it would be better to hard code "MozReview" as the visible description? i only prevented renaming in my patch because i was using it to determine mozreview-ness.
Attachment #8722534 -
Flags: review?(glob) → review+
Assignee | ||
Comment 6•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 5eea1e0..110b14a master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•