Philippe M. Chiasson (:gozer) Assignee
	Description • 9 years ago

Since the localparams override patch landed in bug 1218457, the content of localparams isn't deterministic anymore, specifically, %param_override

This is because using Data::Dumper to dump a hash will return it in hash order by default, which is not deterministic.

You need $Data::Dumper::Sortkeys = 1 for this to work.

This is causing me tons of problems, so submitting the fix

	David Lawrence [:dkl]
	Comment 1 • 9 years ago

Comment on attachment 8683654 [details] [diff] [review]
Sort hash keys when updating localconfig

Review of attachment 8683654 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Install/Localconfig.pm
@@ +280,4 @@
>          chomp($desc);
>          # Make the description into a comment.
>          $desc =~ s/^/# /mg;
> +        local $Data::Dumper::Sortkeys = 1;

Move outside of the foreach loop.

	Philippe M. Chiasson (:gozer) Assignee
	Comment 2 • 9 years ago

Moved $Data::Dumper::Sortkeys out of the main loop
Added a comment.

	David Lawrence [:dkl]
	Comment 3 • 9 years ago

Comment on attachment 8683849 [details] [diff] [review]
Sort hash keys when updating localconfig v2

r=dkl

	David Lawrence [:dkl]
	Comment 4 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   534fc21..60bde01  master -> master

	Philippe M. Chiasson (:gozer) Assignee
	Comment 5 • 9 years ago

(In reply to David Lawrence [:dkl] from comment #4)
> To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
>    534fc21..60bde01  master -> master

Awesome! What do I need to do to have that merged to the production branch so I can deploy this?

	Dylan Hardison [:dylan] (he/him)
	Comment 6 • 9 years ago

(In reply to Philippe M. Chiasson (:gozer) from comment #5)
> (In reply to David Lawrence [:dkl] from comment #4)
> > To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
> >    534fc21..60bde01  master -> master
> 
> Awesome! What do I need to do to have that merged to the production branch
> so I can deploy this?

wait for the push next week.