alexander :surkov (:asurkov) Assignee
	Description • 9 years ago

      No description provided.

	Trevor Saunders (:tbsaunde)
	Comment 1 • 9 years ago

Comment on attachment 8682218 [details] [diff] [review]
patch

>diff --git a/accessible/windows/ia2/ia2Accessible.cpp b/accessible/windows/ia2/ia2Accessible.cpp
>--- a/accessible/windows/ia2/ia2Accessible.cpp
>+++ b/accessible/windows/ia2/ia2Accessible.cpp
>@@ -658,24 +658,25 @@ ia2Accessible::get_accessibleWithCaret(I
>     return CO_E_OBJNOTCONNECTED;
> 
>   int32_t caretOffset = -1;
>   Accessible* accWithCaret = SelectionMgr()->AccessibleWithCaret(&caretOffset);
>   if (acc->Document() != accWithCaret->Document())
>     return S_FALSE;
> 
>   Accessible* child = accWithCaret;
>-  while (child != acc)
>+  while (child && child != acc)

checking if child is a document should be faster, and really this should be its own patch.

	alexander :surkov (:asurkov) Assignee
	Comment 2 • 9 years ago

(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> and really this should be
> its own patch.

what's the point?

	Trevor Saunders (:tbsaunde)
	Comment 4 • 9 years ago

(In reply to alexander :surkov from comment #2)
> (In reply to Trevor Saunders (:tbsaunde) from comment #1)
> 
> > and really this should be
> > its own patch.
> 
> what's the point?

to be clear about the purpose of it is?

	Trevor Saunders (:tbsaunde)
	Comment 5 • 9 years ago

Comment on attachment 8682737 [details] [diff] [review]
patch2

>diff --git a/accessible/windows/ia2/ia2Accessible.cpp b/accessible/windows/ia2/ia2Accessible.cpp
>--- a/accessible/windows/ia2/ia2Accessible.cpp
>+++ b/accessible/windows/ia2/ia2Accessible.cpp
>@@ -658,24 +658,25 @@ ia2Accessible::get_accessibleWithCaret(I
>     return CO_E_OBJNOTCONNECTED;
> 
>   int32_t caretOffset = -1;
>   Accessible* accWithCaret = SelectionMgr()->AccessibleWithCaret(&caretOffset);
>   if (acc->Document() != accWithCaret->Document())
>     return S_FALSE;
> 
>   Accessible* child = accWithCaret;
>-  while (child != acc)
>+  while (!child->IsDoc() && child != acc)
>     child = child->Parent();
> 
>   if (!child)

this is now buggy because child could be non null and point at the document.

	alexander :surkov (:asurkov) Assignee
	Comment 6 • 9 years ago

hope this one is ok :)

	alexander :surkov (:asurkov) Assignee
	Comment 7 • 9 years ago

(In reply to Trevor Saunders (:tbsaunde) from comment #4)
> (In reply to alexander :surkov from comment #2)
> > (In reply to Trevor Saunders (:tbsaunde) from comment #1)
> > 
> > > and really this should be
> > > its own patch.
> > 
> > what's the point?
> 
> to be clear about the purpose of it is?

proper commit message should work here

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4761642b93dc

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/4761642b93dc