Closed
Bug 1219528
Opened 9 years ago
Closed 9 years ago
make AccessiblWrap::accNavigate work with proxies
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(4 files)
1.48 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
2.12 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
926 bytes,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8680416 -
Flags: review?(dbolter)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8680417 -
Flags: review?(dbolter)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8680418 -
Flags: review?(dbolter)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8680419 -
Flags: review?(dbolter)
Updated•9 years ago
|
Attachment #8680416 -
Flags: review?(dbolter) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8680417 [details] [diff] [review] make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of AccessibleWrap::accNavigate deal with proxies Review of attachment 8680417 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/windows/msaa/AccessibleWrap.cpp @@ +1032,5 @@ > > switch(navDir) { > case NAVDIR_FIRSTCHILD: > + if (accessible->IsProxy()) { > + if (accessible->Proxy()->MustPruneChildren()) { I think you forgot to ! the condition here and elsewhere.
Updated•9 years ago
|
Attachment #8680418 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8680419 -
Flags: review?(dbolter) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8680417 [details] [diff] [review] make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of AccessibleWrap::accNavigate deal with proxies Review of attachment 8680417 [details] [diff] [review]: ----------------------------------------------------------------- I guess I won't need another patch so r=me with yesterday's comment addressed.
Attachment #8680417 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to David Bolter [:davidb] from comment #5) > Comment on attachment 8680417 [details] [diff] [review] > make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of > AccessibleWrap::accNavigate deal with proxies > > Review of attachment 8680417 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/windows/msaa/AccessibleWrap.cpp > @@ +1032,5 @@ > > > > switch(navDir) { > > case NAVDIR_FIRSTCHILD: > > + if (accessible->IsProxy()) { > > + if (accessible->Proxy()->MustPruneChildren()) { > > I think you forgot to ! the condition here and elsewhere. err yeah, that was pretty silly of me.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cee6fec09c83 https://hg.mozilla.org/integration/mozilla-inbound/rev/0cb69299172e https://hg.mozilla.org/integration/mozilla-inbound/rev/3c82b46589ec https://hg.mozilla.org/integration/mozilla-inbound/rev/5167704c5d9a
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cee6fec09c83 https://hg.mozilla.org/mozilla-central/rev/0cb69299172e https://hg.mozilla.org/mozilla-central/rev/3c82b46589ec https://hg.mozilla.org/mozilla-central/rev/5167704c5d9a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 10•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/cee6fec09c83 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0cb69299172e https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3c82b46589ec https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/5167704c5d9a
status-b2g-v2.5:
--- → fixed
Comment 11•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
Updated•7 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•