Closed Bug 1219528 Opened 9 years ago Closed 9 years ago

make AccessiblWrap::accNavigate work with proxies

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(4 files)

      No description provided.
Attachment #8680416 - Flags: review?(dbolter) → review+
Comment on attachment 8680417 [details] [diff] [review]
make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of AccessibleWrap::accNavigate deal with proxies

Review of attachment 8680417 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/windows/msaa/AccessibleWrap.cpp
@@ +1032,5 @@
>  
>    switch(navDir) {
>      case NAVDIR_FIRSTCHILD:
> +      if (accessible->IsProxy()) {
> +        if (accessible->Proxy()->MustPruneChildren()) {

I think you forgot to ! the condition here and elsewhere.
Attachment #8680418 - Flags: review?(dbolter) → review+
Attachment #8680419 - Flags: review?(dbolter) → review+
Comment on attachment 8680417 [details] [diff] [review]
make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of AccessibleWrap::accNavigate deal with proxies

Review of attachment 8680417 [details] [diff] [review]:
-----------------------------------------------------------------

I guess I won't need another patch so r=me with yesterday's comment addressed.
Attachment #8680417 - Flags: review?(dbolter) → review+
(In reply to David Bolter [:davidb] from comment #5)
> Comment on attachment 8680417 [details] [diff] [review]
> make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of
> AccessibleWrap::accNavigate deal with proxies
> 
> Review of attachment 8680417 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/windows/msaa/AccessibleWrap.cpp
> @@ +1032,5 @@
> >  
> >    switch(navDir) {
> >      case NAVDIR_FIRSTCHILD:
> > +      if (accessible->IsProxy()) {
> > +        if (accessible->Proxy()->MustPruneChildren()) {
> 
> I think you forgot to ! the condition here and elsewhere.

err yeah, that was pretty silly of me.
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: