Closed
Bug 1219299
Opened 9 years ago
Closed 9 years ago
rework aria-owns implementation
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
57.85 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8680076 -
Flags: review?(yzenevich)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → surkov.alexander
Comment 1•9 years ago
|
||
Comment on attachment 8680076 [details] [diff] [review] patch Review of attachment 8680076 [details] [diff] [review]: ----------------------------------------------------------------- Looks good will try this patch on B2G vs existing. ::: accessible/generic/DocAccessible.cpp @@ +731,5 @@ > // elements. > if (aModType != nsIDOMMutationEvent::ADDITION) > RemoveDependentIDsFor(accessible, aAttribute); > > + if (aAttribute == nsGkAtoms::id && aElement->HasID()) { Would it make sense to have aElement->HasID() check inside RelocateARIAOwnedIfNeeded? @@ +2096,5 @@ > + oldParent->InsertChildAt(oldIdxInParent, aChild); > + return false; > + } > + > + // The child may stolen from other ARIA owns element. Nit: may be stolen ::: accessible/tests/mochitest/events/test_aria_menu.html @@ +151,5 @@ > // Do tests > > var gQueue = null; > > + gA11yEventDumpToConsole = true; // debuging I guess this should be commented out.
Attachment #8680076 -
Flags: review?(yzenevich) → review+
Comment 3•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d3a2e391df48
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 4•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d3a2e391df48
status-b2g-v2.5:
--- → fixed
Comment 5•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•