alexander :surkov (:asurkov) Assignee
	Description • 9 years ago

      No description provided.

	Yura Zenevich [:yzen] (please use "needinfo")
	Comment 1 • 9 years ago

Comment on attachment 8680076 [details] [diff] [review]
patch

Review of attachment 8680076 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good will try this patch on B2G vs existing.

::: accessible/generic/DocAccessible.cpp
@@ +731,5 @@
>    // elements.
>    if (aModType != nsIDOMMutationEvent::ADDITION)
>      RemoveDependentIDsFor(accessible, aAttribute);
>  
> +  if (aAttribute == nsGkAtoms::id && aElement->HasID()) {

Would it make sense to have aElement->HasID() check inside RelocateARIAOwnedIfNeeded?

@@ +2096,5 @@
> +    oldParent->InsertChildAt(oldIdxInParent, aChild);
> +    return false;
> +  }
> +
> +  // The child may stolen from other ARIA owns element.

Nit: may be stolen

::: accessible/tests/mochitest/events/test_aria_menu.html
@@ +151,5 @@
>      // Do tests
>  
>      var gQueue = null;
>  
> +    gA11yEventDumpToConsole = true; // debuging

I guess this should be commented out.

	Pulsebot
	Comment 2 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a2e391df48

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 3 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d3a2e391df48

	Carsten Book [:Tomcat]
	Comment 4 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d3a2e391df48

	Carsten Book [:Tomcat]
	Comment 5 • 9 years ago

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion