:Gijs (he/him) Assignee
	Description • 9 years ago

This is just a pref flip, but there we go.

	Pulsebot
	Comment 2 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/1bce0debbdcd

	Carsten Book [:Tomcat]
	Comment 3 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/1bce0debbdcd

	:Gijs (he/him) Assignee
	Comment 4 • 9 years ago

Comment on attachment 8678078 [details] [diff] [review]
flip OSK pref on release builds,

Approval Request Comment
[Feature/regressing bug #]: on-screen keyboard support on Windows 8+
[User impact if declined]: no on-screen keyboard support on Windows 8+ when 43 hits beta/release
[Describe test coverage new/current, TreeHerder]: no, because our infrastructure test machines have keyboards and because the presence of the keyboard, or lack thereof, is hard to test because it isn't a part of Firefox.
[Risks and why]: low, this is just a pref flip - we could flip it back halfway through beta (or even just disable it on win8/win8.1, but leave it in for win10) if issues did appear, and this feature has been around in Nightly for a while now. We believe all outstanding issues with it are fixed.
[String/UUID change made/needed]: no.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 5 • 9 years ago

Comment on attachment 8678078 [details] [diff] [review]
flip OSK pref on release builds,

Great, let's uplift this, on-screen keyboard support is good to have.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 6 • 9 years ago

We should give on-screen keyboard support some extra QE attention during 43 beta to make sure it looks good. Like Gijs says, if there are major problems we can turn it off at some point during beta.

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/3409c1d9354a

	Vasilica Tamas, QA [:vtamas]
	Comment 8 • 9 years ago

Do we have a meta for on-screen keyboard support? Or should I make sure any upcoming bugs are added to this one's dependencies?

	:Gijs (he/him) Assignee
	Comment 9 • 9 years ago

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #8)
> Do we have a meta for on-screen keyboard support? Or should I make sure any
> upcoming bugs are added to this one's dependencies?

Either this or bug 1007063 will be reasonable. Please also CC me and :jaws.

	Vasilica Tamas, QA [:vtamas]
	Comment 10 • 9 years ago

I confirm that the ui.osk.enabled is true by default and the on-screen keyboard is successfully displayed on Firefox 43 beta 8 (20151201152349) and Firefox 44.0a2 (2015-12-02) using Windows 8.1 64-bit and Windows 10 64-bit under a Dell Xps 12.