J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Reporter
	Description • 9 years ago

If you have xpcshell tests that need files from /browser, you currently have to add:

firefox-appdir = browser

to the test manifest.

This is unnecessary busy work, and it also prevents those tests from running on other apps where this is the incorrect appdir.

It's also the only appdir setting ever used in the tree.  Let's special case Firefox builds instead, and remove the option.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Reporter
	Comment 1 • 9 years ago

I think I've been able to work around this for now.  It doesn't actually block tests on other apps, since the appdir isn't consulted for them.  Still, it's annoying to set for Firefox.

	(not currently active) Ted Mielczarek
	Comment 2 • 9 years ago

This was added to support testing Metro/webruntime stuff, but having it default to "browser" would probably be fine. Those tests will presumably fail if Thunderbird or Seamonkey tried to run them.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Reporter
	Comment 3 • 9 years ago

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> This was added to support testing Metro/webruntime stuff, but having it
> default to "browser" would probably be fine. Those tests will presumably
> fail if Thunderbird or Seamonkey tried to run them.

That's what I tried first, but unfortunately there are quite a few tests that require the current default of **not** passing the Firefox app dir...  So, either all those tests need to change or they need to opt out of the app dir...

Doesn't seem like there is an easy fix here.