Boris Zbarsky [:bzbarsky] Assignee
	Description • 9 years ago

See bug 1172205 comment 39.  We end up in CacheFileUtils::AppendKeyPrefix on those urls and then end up with different key prefixes for the anon and non-anon case.  Which means we need a way to do anon prefetch.

Most simply, could we just support @crossorigin on <link rel="prefetch">?

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 2 • 9 years ago

Drew, I kicked off some test builds with this patch.  I'll post a link to them here once they complete.

With those builds, I think your test from bug 1172205 comment 39 should work the way you want, if you use <link rel="prefetch" crossorigin"> to do the prefetching.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 3 • 9 years ago

Builds:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bzbarsky@mozilla.com-62cf7402e690/try-linux64/firefox-44.0a1.en-US.linux-x86_64.tar.bz2
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bzbarsky@mozilla.com-62cf7402e690/try-macosx64/firefox-44.0a1.en-US.mac.dmg
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bzbarsky@mozilla.com-62cf7402e690/try-win32/firefox-44.0a1.en-US.win32.zip

	Drew Stamps
	Comment 4 • 9 years ago

Thank you, Boris.

Attempting to open the linked Mac OS build, I get the error: "Nightly" is damaged and can't be opened.

	Drew Stamps
	Comment 5 • 9 years ago

Also, I added a page in bug 1172205 comment 41 that has the same prefetch tag but with the crossorigin="anonymous" attribute.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 6 • 9 years ago

> I get the error: "Nightly" is damaged and can't be opened.

Is that opening the dmg, or running the resulting binary?  I just tried downloading it and copying to my desktop and running it and it seems to work fine....

	Drew Stamps
	Comment 7 • 9 years ago

The dmg opens fine. When attempting to launch the binary, Mac OS shows a security icon and a progress bar, and a message about verifying the file. That then ends in the error message.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 8 • 9 years ago

Huh.  Odd...  I can run it fine from here (at least via the command line, by running Nightly.app/Contents/MacOS/firefox from Terminal).

	u408661
	Comment 9 • 9 years ago

Comment on attachment 8673853 [details] [diff] [review]
So perhaps like this

Review of attachment 8673853 [details] [diff] [review]:
-----------------------------------------------------------------

The code itself looks reasonable to me. I haven't fully thought through the idea of enforcing CORS on prefetch, but it seems right (CORS would be enforced on the real fetch later on, anyway). So I think it's worth throwing at the internet and seeing if anything breaks :)

	u408661
	Comment 10 • 9 years ago

(In reply to Drew Stamps from comment #7)
> The dmg opens fine. When attempting to launch the binary, Mac OS shows a
> security icon and a progress bar, and a message about verifying the file.
> That then ends in the error message.

Are you attempting to launch directly from the dmg? I seem to remember having that same problem if I don't copy the app to a writeable directory, but I could be wrong.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 11 • 9 years ago

I guess there's no spec for this prefetching stuff so we can just unilaterally do it... OK, then.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 12 • 9 years ago

Let's try for actual review, with a commit message and all

	Drew Stamps
	Comment 13 • 9 years ago

Thanks, Boris. Nightly launches for me from the command line.

And... the change seems to work for my sample pages. Excellent!

	Pulsebot
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/70745587c5d4

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 15 • 9 years ago

Not sure whether we have real docs for this anywhere...

	Carsten Book [:Tomcat]
	Comment 16 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/70745587c5d4

	Jean-Yves Perrier [:teoli]
	Comment 17 • 9 years ago

(In reply to Boris Zbarsky [:bz] from comment #15)
> Not sure whether we have real docs for this anywhere...

We have; I've updated: https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types

and
https://developer.mozilla.org/en-US/Firefox/Releases/44#HTML