zouyi(Leave from Mozilla) Reporter
	Description • 9 years ago

[1.Description]:
[Flame KK v2.5][Browser]User opens a video in the YouTube site, and activates Full Screen mode via controls. When user switches between portrait and landscape mode, a half-screen blank area will flash past.
Found time:04:29.
See attachment:logcat_0429.txt, Flame KK v2.5.3gp.

[2.Testing Steps]: 
1. Launch the Browser App from Homescreen.
2. In the Browser navigate to "www.youtube.com". 
3. Search for and select a video to play.
4. Activate Full Screen mode via controls. 
5. Flip the phone to landscape mode. 
6. Flip the phone back to portrait mode. 

[3.Expected Result]: 
Step 5&Step6: The video displays correctly without any flickering occurring.

[4.Actual Result]: 
Step 5&Step6: A half-screen blank area will flash past.

[5.Reproduction build]: 
Device: Aries KK 2.5 eng(Unaffected)
Build ID               20151010114808
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b68eab795f9de072bee12821b0f09422e5aa0da9
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151010.110754
Firmware Date          Sat Oct 10 11:08:02 UTC 2015
Bootloader             s1

Device: Aries KK 2.5 user(Unaffected)
Build ID               20151010115114
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b68eab795f9de072bee12821b0f09422e5aa0da9
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151010.111019
Firmware Date          Sat Oct 10 11:10:27 UTC 2015
Bootloader             s1

Device: Flame KK 2.5 eng(Affected)
Build ID               20151011150208
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b68eab795f9de072bee12821b0f09422e5aa0da9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151011.182946
Firmware Date          Sun Oct 11 18:29:58 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 user (319M/512M/1G) (Affected)
Build ID               20151011150208
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b68eab795f9de072bee12821b0f09422e5aa0da9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151011.183940
Firmware Date          Sun Oct 11 18:39:52 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.2(Unaffected)
Build ID               20151011032503
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ab6c34bfacf7
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151011.064600
Firmware Date          Sun Oct 11 06:46:11 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
6073

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 3 • 9 years ago

This may be related to bug 1097202.

	Adam Alldredge [:AdamA][Inactive]
	Comment 4 • 9 years ago

This issue is also occurring in Aries 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151012110146
Gaia: 87f5c9d55ab6a77dcfa48a3f3a8b4f5016f3c657
Gecko: 0b69d304f861d0038fb78f1d52b0f5d13ef7c6fe
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
A half-screen blank area will flash past.
--------------------------------------------
Downgrading from smoke blocker to dogfood blocker per IRC conversation with Nhirata.

	Tony(Leave from Mozilla)
	Comment 5 • 9 years ago

Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Build ID               20150902125723
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gaia Date              2015-09-02 17:52:11
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/1dbf8850f7ed7a3181a09ec1adeda7c4716ccb6c
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150904.075851
Firmware Date          Fri Sep  4 07:59:01 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Build ID               20150902132021
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gaia Date              2015-09-02 17:52:11
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/656880a5febe554231e320936e8d88c8bd0c2c38
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150904.075851
Firmware Date          Fri Sep  4 07:59:01 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES NOT repro
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/1dbf8850f7ed7a3181a09ec1adeda7c4716ccb6c

First Broken Gecko & Last Working Gaia – issue DOES repro
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/656880a5febe554231e320936e8d88c8bd0c2c38

Gecko pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1dbf8850f7ed7a3181a09ec1adeda7c4716ccb6c&tochange=656880a5febe554231e320936e8d88c8bd0c2c38

	Gregor Wagner [:gwagner]
	Comment 6 • 9 years ago

This regression-window doesn't look right. The gecko changes were only in testing code. Can we double check the regression window?

	Gregor Wagner [:gwagner]
	Comment 7 • 9 years ago

Why is this even a dogfood blocker? Whats the user impact here?

	Dylan Oliver [:doliver]
	Comment 8 • 9 years ago

(In reply to Adam Alldredge [:AdamA] from comment #4)
> Result:
> A half-screen blank area will flash past.
> --------------------------------------------
> Downgrading from smoke blocker to dogfood blocker per IRC conversation with
> Nhirata.

I can't understand how this qualifies for either. It's a bug, let's fix it, but impact is negligible for dogfooders and testers.

	Geoff Brown [:gbrown]
	Comment 9 • 9 years ago

(In reply to Gregor Wagner [:gwagner] from comment #6)
> This regression-window doesn't look right. The gecko changes were only in
> testing code. Can we double check the regression window?

I agree. My changes should only affect tests; I cannot imagine how they would affect browser behavior.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 10 • 9 years ago

Anyone using video for browser: ie facebook and youtube will hit this issue and it will be a common complaint about the build.

There are related bugs that can hit this as well such as the screen going off, and people will wonder what happened.

	Dylan Oliver [:doliver]
	Comment 11 • 9 years ago

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #10)
> Anyone using video for browser: ie facebook and youtube will hit this issue
> and it will be a common complaint about the build.

I am not suggesting it is not a bug, or even a 2.5 blocker. What I am saying is that we can't block *dogfood* on relatively minor and temporary visual issues like this. 

> There are related bugs that can hit this as well such as the screen going
> off, and people will wonder what happened.

Presumably those are other bugs, not this one.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 12 • 9 years ago

Oh oops.  Sorry, I was thinking about the other dogfood blocker when I wrote my last comment.  My mistake.  I agree.

	Sxean Lee-David [:sxean]
	Comment 13 • 9 years ago

Mozilla Inbound: 

Last Working: 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150902132021
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: 656880a5febe554231e320936e8d88c8bd0c2c38
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0


First Broken: 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150902133227
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: 137ead96908ad9a0544c587092b4e4fa386a0fee
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

PushLog: 

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=656880a5febe554231e320936e8d88c8bd0c2c38&tochange=137ead96908ad9a0544c587092b4e4fa386a0fee

Note: 
This issue may have been caused by changes in Bug 1201217

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 14 • 9 years ago

Kartikaya this issue seems to have been caused by the changes for bug 1201217.  Can you please take a look?

	Botond Ballo [:botond] Assignee
	Comment 15 • 9 years ago

(In reply to Jayme Mercado [:JMercado] from comment #14)
> Kartikaya this issue seems to have been caused by the changes for bug
> 1201217.

That seems unlikely. The changes in bug 1201217 were to Fennec-only code, while this is a B2G regression.

	Botond Ballo [:botond] Assignee
	Comment 16 • 9 years ago

(In reply to Sxean Lee-David [:sxean] from comment #13)
> PushLog: 
> 
> http://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=656880a5febe554231e320936e8d88c8bd0c2c38&tochange=137e
> ad96908ad9a0544c587092b4e4fa386a0fee

This pushlog also contains bug 1200399. That patch moves a line of code that sets AsyncCompositionManager::mIsFirstPaint to false, into an Android-only block (where previously it was unconditional). That value, however, is read on non-Android platforms, too, in code that has to do with screen rotation [1]. I'm willing to bet that's the problem.

[1] https://dxr.mozilla.org/mozilla-central/rev/ccf288f658211b6cfab33c458aaf033baed2375b/gfx/layers/ipc/CompositorParent.cpp#1220

	Botond Ballo [:botond] Assignee
	Comment 17 • 9 years ago

Bug 1213762 - Clear AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too. r=mstange

	Botond Ballo [:botond] Assignee
	Comment 18 • 9 years ago

Comment on attachment 8675167 [details]
MozReview Request: Bug 1213762 - Clear AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too. r=mstange

Naoki, would you be able to test with this patch applied and see if it fixes the problem?

	William Hsu [:whsu]
	Comment 19 • 9 years ago

(In reply to Botond Ballo [:botond] (at standards meeting Oct 19-24) from comment #18)
> Comment on attachment 8675167 [details]
> MozReview Request: Bug 1213762 - Clear
> AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too.
> r=mstange
> 
> Naoki, would you be able to test with this patch applied and see if it fixes
> the problem?

Hi, Zouyi,

Please help share Naoki's workload.
attachment 8675167 [details] needs your verification.
Thank you.

	zouyi(Leave from Mozilla) Reporter
	Comment 20 • 9 years ago

Hi, William,
     This bug can not be reproduced after build this patch(attachment 8675167 [details]).

	William Hsu [:whsu]
	Comment 21 • 9 years ago

Hi, Botond,

As per comment 20 mentioned, your patch can solve this issue.
Thank you.

	Botond Ballo [:botond] Assignee
	Comment 22 • 9 years ago

Great! I'll post the fix for review, then.

	Botond Ballo [:botond] Assignee
	Comment 23 • 9 years ago

Comment on attachment 8675167 [details]
MozReview Request: Bug 1213762 - Clear AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too. r=mstange

Bug 1213762 - Clear AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too. r=mstange

	Markus Stange [:mstange]
	Comment 24 • 9 years ago

Comment on attachment 8675167 [details]
MozReview Request: Bug 1213762 - Clear AsyncCompositionManager::mIsFirstPaint on non-Android platforms, too. r=mstange

https://reviewboard.mozilla.org/r/22335/#review20071

	Pulsebot
	Comment 25 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/563ca0487044

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 26 • 9 years ago
backout bugherder merge

https://hg.mozilla.org/mozilla-central/rev/563ca0487044

	Martin Shuman [:Marty]
	Comment 27 • 9 years ago

This issue is resolved fixed on the latest Aries and Flame 2.5 builds.
The video is able to transition between Landscape and Portrait orientation without visual flicker or flashing.

Environmental Variables:
Device: Aries 2.5
BuildID: 20151021111747
Gaia: 32d827a70af90a05918f234e5b16b35d5d2a07e8
Gecko: d43374e6970311c0a14f25f3ec09d2a30448a2b2
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20151021064220
Gaia: 32d827a70af90a05918f234e5b16b35d5d2a07e8
Gecko: 473aefe5bd85842eeb142e0cde8e2cd21edbf40b
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0