Implement MediaDeviceInfo.groupId
Categories
(Core :: WebRTC: Audio/Video, defect, P3)
Tracking
()
| backlog | webrtc/webaudio+ |
People
(Reporter: jib, Assigned: achronop)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
"The origin-unique group identifier for the source of the MediaStreamTrack. Two devices have the same group identifier if they belong to the same physical device; for example, the audio input and output devices representing the speaker and microphone of the same headset would have the same groupId." http://w3c.github.io/mediacapture-main/getusermedia.html#sec-track-properties
|
||
Updated•9 years ago
|
|
||
Updated•9 years ago
|
|
||
Comment 1•7 years ago
|
||
Mass change P2->P3 to align with new Mozilla triage process.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27976b9441c5d3000725e95aa95e64b34b3d5bb7
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d84ae771e7ead5722267128541777c42bba5ce3
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Spec in [1] mentions: "The browsing session-unique group identifier for the source of the MediaStreamTrack."
[1] https://www.w3.org/TR/mediacapture-streams/#constrainable-properties
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Comment 9•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf4f656ade77e5478d5213edbee3d8f61ea15fb3
|
|
Assignee | |
Comment 10•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=096f09816099e9aa523930aafa64133faa7d2e7f
|
|
Assignee | |
Comment 11•5 years ago
|
||
I would like to put here for reference that the correlation of video and audio devices relies on device names. If an audio device's name contains the name of the video device, then, this video device will take the group id of that audio device. The logic compares the input devices first, if it finds a much then comparison stops, if not it continues with the output devices. In addition to that if there is more than one much we do not attempt to correlate the devices. In general since this is a guess we try to minimize the probability of false positive.
On the other hand the groupId between audio devices that belong to the same physical device is provided by cubeb and it's always correct.
|
||
Comment 12•5 years ago
|
||
Pushed by achronopoulos@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6903f0739e83 Add group id in various MediaManager classes. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/f78c357f2f5f Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/ec1da6bbf1a7 Session-unique group id. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/6208d9e15f3d Correlate video device group id based on device name. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/118792523194 Update mochitest to expect group id. r=pehrsons
|
||
Comment 13•5 years ago
|
||
Backed out for bustages on MediaEngineDefault.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/f63a07c8426b5f2286870f0b55c2957a8679d60a
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=232626063&revision=1187925231944ef5c076e75e04fb3f321570fe7d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232625594&repo=autoland&lineNumber=18874
|
|
||
Comment 14•5 years ago
|
||
Pushed by achronopoulos@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19934e7183f7 Add group id in various MediaManager classes. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/7e561fa634f7 Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/1cac58480c6a Session-unique group id. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/a90a2cb536f3 Correlate video device group id based on device name. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/75033c11fa3c Update mochitest to expect group id. r=pehrsons
|
|
Assignee | |
Comment 16•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5a5557bda40649437a83f89138c3ea09747cb76
|
||
Comment 17•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/19934e7183f7
https://hg.mozilla.org/mozilla-central/rev/7e561fa634f7
https://hg.mozilla.org/mozilla-central/rev/1cac58480c6a
https://hg.mozilla.org/mozilla-central/rev/a90a2cb536f3
https://hg.mozilla.org/mozilla-central/rev/75033c11fa3c
|
||
Comment 18•5 years ago
|
||
Note to MDN writers:
I've added a note about this to the Fx67 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#Media_Web_Audio_and_WebRTC
In terms of other work:
- The BCD needs updating
- the groupId page needs updating to fill it in a bit (e.g. adding an Example)
|
|
||
Comment 19•5 years ago
|
||
Added example to the page https://developer.mozilla.org/en-US/docs/Web/API/MediaDeviceInfo/groupId; also updated and expanded the text slightly (and the example has a long explanation of how it works).
BCD claimed this was added back in Firefox 35 or so, but I've submitted a PR to change it to 67.
Submitted PR 4093 to update BCD
Added a sentence to the existing note on Firefox 67 for developers to explain that the property has existed since Firefox 39, but didn't actually group related items until 67.
|
||
Updated•5 years ago
|
Description
•