Daniel Holbert [:dholbert] Assignee
	Description • 9 years ago

Filing this bug on enabling the "layout.css.prefixes.webkit" pref by default.

At this point, I think the main things blocking that are -webkit-box styling (bug 1208635) and webkit gradients (bug 1132748).  There may be other webkit prefixed properties that we add later on, but those don't need to block the rest of them from being enabled.

(Really, we could probably enable this now and start testing what's already in.  But I'd rather not quite yet, because having this turned off means we can land -webkit-box & prefixed gradient support in incremental pieces, behind the pref, without having to worry about the intermediate states causing breakage on random sites.)

(Also not sure yet if this will be a "enable it, period" bug or an "enable it on Nightly/Aurora" bug. Might start with the former, and then we can always pref it off on branches if we discover problems & need to hold it for a release or two.)

	Mike Taylor [:miketaylr]
	Comment 1 • 9 years ago

(In reply to Daniel Holbert [:dholbert] (less responsive Oct 9-12 & 15-18) from comment #0)
> [...] having this turned off means we
> can land -webkit-box & prefixed gradient support in incremental pieces,
> behind the pref, without having to worry about the intermediate states
> causing breakage on random sites.)

This sounds sensible.
 
> (Also not sure yet if this will be a "enable it, period" bug or an "enable
> it on Nightly/Aurora" bug. Might start with the former, and then we can
> always pref it off on branches if we discover problems & need to hold it for
> a release or two.)

Also SGTM.

	Daniel Holbert [:dholbert] Assignee
	Comment 2 • 9 years ago

(Sorry, all mentions of "bug 1132748" here were really supposed to say "bug 1210575". The former was for CSSUnprefixingService-backed gradient support; the latter is for native support.)

	Daniel Holbert [:dholbert] Assignee
	Comment 4 • 8 years ago

Here's the patch. I think this is ready to land, once bug 1208344 is in.

As noted at the end of comment 0, I'm optimistically hoping this can just ride the trains -- hence, no ifndef MOZ_RELEASE guard here -- but we can always pref it off on a release channel if we discover some fallout.

	Daniel Holbert [:dholbert] Assignee
	Comment 5 • 8 years ago

(Note that I'm not bothering to pref off the js-based CSS Unprefixing Service pref here -- per bug 1210575 part 4, this newer pref will disable the CSS Unprefixing Service the hood anyway. And if we (or users) want to revert this bug's change, there's only one pref to flip to restore the old behavior, instead of two.  Once this new impl has stuck, we can just rip out the unprefixing service entirely.)

	Daniel Holbert [:dholbert] Assignee
	Comment 6 • 8 years ago

*under the hood

	Cameron McCormack (:heycam)
	Comment 7 • 8 years ago

Comment on attachment 8703064 [details] [diff] [review]
patch v1: flip the pref

Review of attachment 8703064 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray!

	Mike Taylor [:miketaylr]
	Comment 8 • 8 years ago

\o/, thanks for all the work you put in to make this happen Daniel and Cameron!

	Daniel Holbert [:dholbert] Assignee
	Comment 9 • 8 years ago

Likewise!

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d66cd0ec433

	Pulsebot
	Comment 10 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fbf850dc78d

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9fbf850dc78d

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 12 • 8 years ago

Marking 44 unaffected (since this landed in 46)

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 13 • 8 years ago

Noting this is moving to aurora soon but will stay on aurora (bug 1238827)

	Sylvestre Ledru [:Sylvestre]
	Comment 14 • 8 years ago

Release Note Request (optional, but appreciated)
[Why is this notable]: Important change for compatibility
[Suggested wording]: Improved Web compatibility by supporting WebKit CSS prefixed properties (via layout.css.prefixes.webkit)
[Links (documentation, blog post, etc)]: Do we have an official blog post which explains that?

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 15 • 8 years ago

This is noted for 46 as "Added support for WebKitCSSMatrix to improve mobile Web compatibility"

Can you suggest a link for the release notes? (Daniel - I can always add in the link next week when you are back, no rush)

	Daniel Holbert [:dholbert] Assignee
	Comment 16 • 8 years ago

Webkit-prefixed features are not actually shipping past Aurora right now (as of bug 1238827). So, we probably want to remove that relnote for 46beta & 46release.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 17 • 8 years ago

Oh, right! Thanks. I have removed it. My note was actually for bug 717722, "Added support for WebKitCSSMatrix to improve mobile Web compatibility".  I think these are basically the same note, and that bug also mentions staying in aurora. 

Ritu, should we move the note to 47?

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 18 • 8 years ago

Done. I added it to Fx47 (aurora) release notes.

	Daniel Holbert [:dholbert] Assignee
	Comment 19 • 8 years ago

Liz, looks like this is still in the Firefox 46 release notes ("Gecko now accepts the -webkit- prefixed version of some properties;")[1], and it's caused some confusion on hacker news[2].

Someone already edited the release notes to clarify that you have to tweak the pref, but we probably should just remove this piece of the release notes entirely, right?  I don't think we normally announce disabled-by-default features there. (And I thought we had removed it already in earlier versions of 46 release notes, per comment 17.)  I'm guessing this release-notes inclusion was just an accident.

[1] https://developer.mozilla.org/en-US/Firefox/Releases/46
[2] https://news.ycombinator.com/item?id=11579148

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 20 • 8 years ago

I don't work on the MDN developer release notes - only on what we put onto mozilla.org for the main Firefox release notes.
jypenator -- I think that it is probably best to move this note and similar ones to the 47 beta notes, since they aren't yet enabled by default.

	Daniel Holbert [:dholbert] Assignee
	Comment 21 • 8 years ago

Thanks for the clarification! (Note that these webkit prefixing features aren't enabled in 47 beta either, actually -- so 47 beta notes isn't a good place for them either.  They're tentatively slated to be enabled in 48beta+release or 49beta+release -- that's bug 1259345.)

	Sebastian Zartner [:sebo]
	Comment 22 • 8 years ago

(In reply to Daniel Holbert [:dholbert] from comment #19)
> Someone already edited the release notes to clarify that you have to tweak
> the pref, but we probably should just remove this piece of the release notes
> entirely, right?  I don't think we normally announce disabled-by-default
> features there.

These notes are for developers, so we *do* list disabled-by-default features (with a hint for the preference to enable them).

Sebastian