James Teh [:Jamie] Reporter
	Description • 9 years ago

With e10s enabled, events are now fired for proxied accessibles on Windows, but retrieving the accessibles fails. IAccessible::accChild returns E_INVALIDARG.

	Trevor Saunders (:tbsaunde)
	Comment 4 • 9 years ago

Comment on attachment 8668650 [details] [diff] [review]
Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles.

I'm kind of crazy, but I'd probably break these up into separate patches.

also we shouldn't land this part till the ipc reentering stuff is fixed.

>+    if (doc == this) {
>+      AccessibleWrap* proxyWrapper =
>+        GetProxiedAccessibleInSubtree(remoteDocs->ElementAt(i), id);
>+      if (proxyWrapper) {
>+        return proxyWrapper;
>+      }
>+      continue;

nit, blank line after } please

	James Teh [:Jamie] Reporter
	Comment 5 • 9 years ago

Aside from fixing the nit, this version also fixes the case where one tries to retrieve a proxied child (c) of a proxied document (d) where accChild is called on the document itself (d).

I'm happy to split these into separate patches if you wish, though it's difficult to come up with summaries for each patch. Also, I don't think it would make sense for these to land separately if that were to happen for whatever reason.

	James Teh [:Jamie] Reporter
	Comment 6 • 9 years ago

Ping! Now that bug 1212906 is fixed, can this be landed or is further work required?

	Trevor Saunders (:tbsaunde)
	Comment 7 • 9 years ago

(In reply to James Teh [:Jamie] from comment #6)
> Ping! Now that bug 1212906 is fixed, can this be landed or is further work
> required?

I was planning on landing it tomorrow :)

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d09d65a73f
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c948f1d2096
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8eb48dac54

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/d2d09d65a73f
https://hg.mozilla.org/mozilla-central/rev/1c948f1d2096
https://hg.mozilla.org/mozilla-central/rev/6e8eb48dac54