Closed Bug 1210234 Opened 9 years ago Closed 9 years ago

Alarms and Timers will show a broken blank screen if they trigger when the device screen is off.

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- verified

People

(Reporter: Marty, Assigned: zbraniecki)

References

()

Details

(Keywords: regression, Whiteboard: [2.5-Daily-Testing][Spark][dogfood-blocker])

Attachments

(2 files)

Description:
If the device screen is off when the alarm or timer triggers, the user will see a blank grey screen with no UI buttons to dismiss it.  There will not be any alarm or timer sound. The user can minimize this with the Home Button, but it will remain present in the Notification tray, and can be reopened.  The user will also not be able to close the app in the Task Manager after this occurs.

Notes:
-This issue does occur if the Lockscreen has been disabled in settings, as long as the screen is still off.
-This issue does NOT occur if the screen is on, but the user is at the lockscreen when the timer triggers.

Repro Steps:
1) Update a Aries to 20150930012954
2) Open the Clock app
3) Set a timer or an alarm to activate in 1 minute
4) Lock the device


Actual:
When the alarm or timer triggers, there is a blank grey pop-up screen that can be minimized, but not closed. 

Expected:
Alarm and Timer pop-ups always function properly.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150930012954
Gaia: d8801ebb469756aea1179627aef3b37fbd9a9977
Gecko: 4713427f96c195020db07db02450b546ab626987
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 8/10
See attached: logcat, video
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Whiteboard: [2.5-Daily-Testing][Spark] → [2.5-Daily-Testing][Spark][dogfood-blocker]
This issue DOES occur on Flame 2.5 builds.
When the alarm or timer triggers, there is a blank grey pop-up screen that can be minimized, but not closed.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150930030225
Gaia: 1bc0b19527777ffee494962b48db4be857b07d64
Gecko: 891ee0d0ba3ec42b6484cf0205b3c95e21c58f74
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

--------------------------------------

This issue does NOT occur on Flame 2.2 builds.
Alarm and Timer pop-ups always function properly.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150930032502
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: 65ddad73ad6b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
QA Contact: pcheng
Zibi, this looks like fallout from the i18n patch? Also bug 1210190?

[JavaScript Error: "ReferenceError: IntlHelper is not defined" {file: "app://clock.gaiamobile.org/js/onring.js" line: 57}]
Flags: needinfo?(gandalf)
The ringer view triggers from outside index.html; probably just missing an include.
Taking.

So, I can't reproduce it, but I can imagine what's going on:

The file is included, but it's deferred, while onring.js is using alameda, so there's some race condition. The easiest way for me is to undefer intl_helper. Would you be ok with that?
Assignee: nobody → gandalf
Flags: needinfo?(gandalf) → needinfo?(m)
Yeah, that's fine.
Flags: needinfo?(m)
Attachment #8668209 - Flags: review?(m)
Comment on attachment 8668209 [details] [review]
[gaia] zbraniecki:1210234-undefer-intlhelper-in-clock > mozilla-b2g:master

Please note my github comment -- do we need any of the others to be undeferred? r=me for those changes with that considered.
Attachment #8668209 - Flags: review?(m) → review+
Commit: https://github.com/mozilla-b2g/gaia/commit/e1a4ca2a1d5e51463c2f5896cb80f6812619a12f

Martin, can you attempt to reproduce the bug with this change? Thanks!
Flags: needinfo?(mshuman)
I got the latest master [1] with the revision mentioned in comment 10. The screen is not blank anymore, but the alarm doesn't ring until you power up the screen. Moreover, once the pop up here, there is no way to close the timer. Tapping on the close button doesn't have any effect. I would recommend to backout the hotfix, perform the regression window and back out the original regression.

Are you okay with that, Zibi?

[1] 8a367db8038c055f017d235891af7885b8e6ea55
Flags: needinfo?(mshuman) → needinfo?(gandalf)
I forgot you were in the Pacific timezone. In order to get a dogfood update as soon as possible. I performed a git bisect. It pointed out bug 1207044. Another side effect of this patch was: If you set the timer to 1 minute, it'll show 00:00:60 instead of 00:01:00.

Setting as a blocker, as it was preventing a user from closing an alarm, which is one of the happy path of the clock app.

Resolved by backout of bug 1207044[1]. The revert has some conflicts. I resolved them by backing out bug 1210196[2] and its follow up[3]. Finally, the patch landed in comment 10[4] was also removed, because of the effects described in comment 11.

[1] https://github.com/mozilla-b2g/gaia/commit/177b34a6a5c4f90366a6573e1c17c1fae8b643dd
[2] https://github.com/mozilla-b2g/gaia/commit/0333858eeccf285be53826ef43c3a9c8ca3714ec
[3] https://github.com/mozilla-b2g/gaia/commit/1aacacc9df5ff349b4653b235e96d7141faabbe0
[4] https://github.com/mozilla-b2g/gaia/commit/d287c89d677371902256f5ad5331d99b21253d71
Blocks: 1207044, 1210196
Status: NEW → RESOLVED
blocking-b2g: 2.5? → 2.5+
Closed: 9 years ago
QA Contact: pcheng → jlorenzo
Resolution: --- → FIXED
For the record, the backout I made introduced regressions in the Music app: No elapsed/remaining time was displayed, and you couldn't use the timebar to navigar within a song.
That's fixed now. Sorry for the trouble guys!
Flags: needinfo?(gandalf)
This issue is verified fixed on the latest 2.5 Master Flame and Aries builds.
Alarm and Timer pop-ups display and function properly.

Environmental Variables:
Device: Aries 2.5
BuildID: 20151002110438
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: 5f16c6c2b969f70e8da10ee34853246d593af412
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20151002030232
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: 5f16c6c2b969f70e8da10ee34853246d593af412
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
Status: RESOLVED → VERIFIED
Flags: needinfo?(jmercado)
Flags: needinfo?(jmercado)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: