Closed
Bug 1210108
Opened 9 years ago
Closed 9 years ago
Emit object:state-changed:showing event for doorhangers
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: jdiggs, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
930 bytes,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
When a doorhanger is shown to the user in Windows, as I understand it, an alert event is emitted along with whatever event is emitted to indicate the accessible tree has been modified. Unfortunately, ATK/AT-SPI2 doesn't have an alert event. We could add one. But that would not help users now, nor would it help users who do not update to the latest version of their distro in the future. I think a reasonable alternative would be to emit object:state-changed:showing when a doorhanger's showing state changes. This is the event emitted by other applications and toolkits implementing ATK when tooltips, notifications, and the like are shown.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8668079 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8668079 -
Attachment is obsolete: true
Attachment #8668079 -
Flags: review?(tbsaunde+mozbugs)
Attachment #8668083 -
Flags: review?(tbsaunde+mozbugs)
Comment 3•9 years ago
|
||
Comment on attachment 8668083 [details] [diff] [review] patch2 >+ // ATK doesn't have a better match, Orca knows how to handle that. that comment doesn't seem great. Why don't you explicitly says it hack using state change showing events as alert events? or something like that? >+ atk_object_notify_state_change(&atkObj, ATK_STATE_SHOWING, true); stray &
Attachment #8668083 -
Flags: review?(tbsaunde+mozbugs) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/95fb2b552c0d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•7 years ago
|
Assignee: nobody → surkov.alexander
You need to log in
before you can comment on or make changes to this bug.
Description
•