Closed
Bug 1209599
Opened 9 years ago
Closed 9 years ago
group general preferences by category
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: dkl)
References
Details
Attachments
(2 files, 1 obsolete file)
8.37 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
21.92 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
it's getting increasingly trickier to find a preference. we need to add a category to each preference and group by that category in the 'general preferences' tab. my rough guess at the categories would be: api Require API key authentication for API requests reviews & needinfo Block needinfo requests Block review and feedback requests Send me reminders for overdue requests Automatically add me to the CC list of bugs I am requested to review email notifications Add 'New:' to subject line of email sent when a new bug is filed Preferred email format Include X-Bugzilla- headers in BugMail body Language used in email bug editing Position of the Additional Comments box When viewing a bug, show comments in this order When viewing a bug, show all bug activity After changing a bug Show gravatar images when viewing bugs (gone when modal is default) Show my gravatar image to other users (gone when modal is default) Automatically add me to the CC list of bugs I change user interface When viewing a bug, show its corresponding Orange Factor page Display possible duplicates when reporting a new bug Product chooser to use when entering bugs Bugzilla's general appearance (skin) (gone when modal is default) Timezone used to display dates and times Use experimental user interface searching Include comments when performing quick searches (slower) we should also set the following settings to be unchangeable, and hide prefs that are set this way: Field separator character for CSV files default to , Show a quip at the top of each bug list default to off Enable tags for bugs default to on Quote the associated comment when you click on its reply link default on Zoom textareas large when in use (requires JavaScript) default on
Assignee | ||
Comment 1•9 years ago
|
||
- Add category column to setting table - Update Bugzilla::User::Setting::add_setting to take named parameters instead of a growing list. - Updated stock settings by adding proper categories and converting new parameter format in Bugzilla::Install and migrate using Bugzilla::Install::DB - Updated extension add_setting calls to add proper categories and convert to new param format. - Updated userprefs.cgi and settings.html.tmpl to display the preferences separated by their categories. - Disabled preferences are no longer displayed to the instead of simply disabled.
Attachment #8673873 -
Flags: feedback+
Comment on attachment 8673873 [details] [diff] [review] 1209599_1.patch Review of attachment 8673873 [details] [diff] [review]: ----------------------------------------------------------------- r=glob nice! can you also update the template/en/default/admin/settings/edit.html.tmpl to sort settings.key (as much fun as getting a different ordering on each refresh is, it loses entertainment value after a few iterations). ::: Bugzilla/Install.pm @@ +58,5 @@ > sub SETTINGS { > return { > # 2005-03-03 travis@sedsystems.ca -- Bug 41972 > + display_quips => { options => ["on", "off"], default => "on", > + category => 'Searching' }, nit: since we're updating these lines, let's fix the formatting. i love how you've laid it out in the extensions, mirror that formatting here. ::: userprefs.cgi @@ +229,5 @@ > my $user = Bugzilla->user; > > + my %settings; > + my $has_settings_enabled = 0; > + foreach my $name (keys %{ $user->settings }) { these keys need to be sorted
Attachment #8673873 -
Flags: review?(glob) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Schema only patch. Moving r+.
Attachment #8673873 -
Attachment is obsolete: true
Attachment #8674483 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
Schema only: To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 2e2981d..b21167f master -> master
Assignee | ||
Comment 5•9 years ago
|
||
Commit this for the second production push.
Attachment #8674486 -
Flags: review+
looks like test_user_preferences.t needs to be updated: https://public-artifacts.taskcluster.net/TPYAanr-SzS8xEMqmz6iHQ/3/public/logs/live_backing.log
Assignee | ||
Comment 7•9 years ago
|
||
Fix test failures To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git c8cf2b5..861eb8f master -> master
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•