Closed Bug 1208779 Opened 9 years ago Closed 9 years ago

crash in mozilla::a11y::Accessible::IsProxy()

Categories

(Core :: Disability Access APIs, defect)

43 Branch
x86
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 + fixed
firefox44 + fixed

People

(Reporter: davidb, Assigned: tbsaunde)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-0a09a2e1-8786-46fa-98b4-f2a9d2150925.
=============================================================

Looks like it has been around since bug 1196460 landed.

More reports here: http://is.gd/71v46H

I think we need to move this check outside the 64 bit only section of GetChildIDFor:
#ifdef _WIN64
  if (!aAccessible ...
    return 0;
Attachment #8666898 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/106456a09909
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
[Tracking Requested - why for this release]:
This is the top crash for browser processes in Dev Edition 43, can it be uplifted?
Trevor, can you file an uplift approval request for aurora? Will this apply cleanly to aurora?
Flags: needinfo?(tbsaunde+mozbugs)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Trevor, can you file an uplift approval request for aurora? Will this apply
> cleanly to aurora?

I think so.
Flags: needinfo?(tbsaunde+mozbugs)
Comment on attachment 8666898 [details] [diff] [review]
null check aAccessible in GetChildIDFor() for 32 bit as well as 64 bit windows

Approval Request Comment
[Feature/regressing bug #]: a11y e10s work for windows
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]: its been on m-c for a couple days
[Risks and why]: low just adding a null check
[String/UUID change made/needed]:
Attachment #8666898 - Flags: approval-mozilla-aurora?
Comment on attachment 8666898 [details] [diff] [review]
null check aAccessible in GetChildIDFor() for 32 bit as well as 64 bit windows

Fix for top crash; let's take this for aurora
Attachment #8666898 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tracking this since it's a topcrash (and in case it reopens)
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: