Dan Callahan [:callahad] Reporter
	Description • 9 years ago

Reference: https://developer.chrome.com/extensions/extension#property-inIncognitoContext

This is used by the Chrome version of the Reddit Enhancement Suite add-on. The Jetpack version uses sdk/private-browsing's isPrivate(window) function for equivalent functionality.

	Tom S [:evilpie] Assignee
	Comment 1 • 9 years ago

So we have actually implemented this already for content scripts. And that seems to be hit when I inline view an image on reddit with RES. When was this undefined? The documentation claims we should implement this for tabs as well. Additionally I think it also makes sense for popups, because we reload these every time anyway.

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 2 • 9 years ago

I think the one part here is that browser.extension is defined in ext-extension.js, which is part of toolkit. That part of the code isn't supposed to know about tabs or popups. However, extensions.registerAPI can be used to extend the API arbitrarily. So you can use extensions.registerAPI from ext-tabs.js to add inIncognitoMode to browser.extension. And you can use the currentWindow function from there to get the current XUL window.

	Tom S [:evilpie] Assignee
	Comment 3 • 9 years ago

I had written this patch before.

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 4 • 9 years ago

Comment on attachment 8666418 [details] [diff] [review]
wip

Review of attachment 8666418 [details] [diff] [review]:
-----------------------------------------------------------------

This is actually just as good. It does bring up one issue. Right now we're not loading the browser action pop-up in private browsing mode if the window is private. We should probably do that.

	Dan Callahan [:callahad] Reporter
	Comment 5 • 9 years ago

This may be a documentation bug instead of an implementation bug :)

https://wiki.mozilla.org/WebExtensions says "we support only getBackgroundPage and getURL," so I didn't actually try the inIncognitoContext API.

	Tom S [:evilpie] Assignee
	Comment 6 • 9 years ago

>Right now we're not loading the browser action pop-up in private browsing mode if the window is private.
Seems complicated to do right now. They API is not accessible to JS.

	Dan Callahan [:callahad] Reporter
	Comment 7 • 9 years ago

(In reply to Bill McCloskey (:billm) from comment #4)
> Right now we're not loading the browser action pop-up in private browsing mode
> if the window is private. We should probably do that.

It seems like Chrome does that conditionally based on whether or not "incognito": "split" is set in the manifest, per the docs: "True for content scripts running inside incognito tabs, and for extension pages running inside an incognito process. The latter only applies to extensions with 'split' incognito_behavior."

Since we don't currently support that manifest property, I'd propose marking this RESOLVED FIXED.

(I've verified that things look good for content scripts in https://github.com/callahad/webextension-tests/tree/master/incognito_context)

	Dan Callahan [:callahad] Reporter
	Comment 8 • 9 years ago

This no longer blocks Bug 1208765, as :evilpie noted, inIncognitoContext is not at full Chrome parity, but the manner in which RES uses it *is* supported.

	Pulsebot
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b8dd562685d

	Phil Ringnalda (:philor)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/7b8dd562685d