Trevor Saunders (:tbsaunde) Reporter
	Description • 9 years ago

Consider the case that GetChildCountCB is called on an atk object with an accessible not a proxy.  That accessible might be a outerDoc accessible where the child is a proxied document.  to handle that in the accessible case we need to see if we can convert the Accessible* to an OuterDocAccessible* and then get something when we call RemoteChildDoc() on it.

smaug can you fix this? it should be easy ;)

	Trevor Saunders (:tbsaunde) Reporter
	Comment 2 • 9 years ago

Comment on attachment 8664424 [details] [diff] [review]
v1

>-    return static_cast<gint>(accWrap->EmbeddedChildCount());
>+    uint32_t count = accWrap->EmbeddedChildCount();
>+    if (count) {
>+      return static_cast<gint>(count);
>+    }
>+
>+    OuterDocAccessible* outerDoc = accWrap->AsOuterDoc();
>+    if (outerDoc) {
>+      proxy = outerDoc->RemoteChildDoc();
>+    }

oops, I should be more careful, this will return the number of children of the child, not the number of children.  if RemoteChildDoc() returns a proxy we should just return 1, because there is one child that RemoteChildDoc.

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8146f364b03

	Carsten Book [:Tomcat]
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/c8146f364b03