Dimi Lee [ooo 16.04 - 21.04］ Assignee
	Description • 9 years ago

ServiceWorker should use extendableMessageEvent interface instead of MessageEvent
according to
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-interface

	Dimi Lee [ooo 16.04 - 21.04］ Assignee
	Comment 2 • 9 years ago

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Set r+ because this patch is already reviewed in bug 1143717 Comment 21.

	Dimi Lee [ooo 16.04 - 21.04］ Assignee
	Comment 3 • 9 years ago

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1aa3a138c450

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9184d15b52be

	Carsten Book [:Tomcat]
	Comment 5 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9184d15b52be

	Marco Castelluccio [:marco]
	Comment 6 • 9 years ago

Is this going to be backported to Firefox 44?

	Andrew Overholt [:overholt]
	Comment 7 • 9 years ago

Do we need it in 44?

	Marco Castelluccio [:marco]
	Comment 8 • 9 years ago

(For reference, I'm asking because of this: https://github.com/mozilla/serviceworker-cookbook/pull/140#discussion_r46159137)

	Ben Kelly [:bkelly, not reviewing]
	Comment 9 • 9 years ago

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: We need this to maintain compatibility with chrome in service workers.  Its already been noticed by devs so we should uplift it.
[Describe test coverage new/current, TreeHerder]: Tests included.
[Risks and why]: Minimal.  Only affects service workers.
[String/UUID change made/needed]: None.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 10 • 9 years ago

Comment on attachment 8685302 [details] [diff] [review]
Implement ExtendableMessageEvent

SW is planned for 44 and this fix has baked on Nightly for almost ~4 weeks. Let's uplift to Aurora44.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 11 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/3f7cc875e92e

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3f7cc875e92e

	Chris Mills [:cmills]
	Comment 13 • 9 years ago

I've documented this here (see also subpages):

https://developer.mozilla.org/en-US/docs/Web/API/ExtendableMessageEvent

The message event itself is covered here:

https://developer.mozilla.org/en-US/docs/Web/Events/message_%28ServiceWorker%29

And a note has been added to the 44 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/44#Service_Workers

Let me know if thus makes sense, or if I have got confused here. Thanks!