Xidorn Quan [:xidorn] UTC+11 Assignee
	Description • 9 years ago

We are able to restrict internal properties to UA sheets only since bug 1069192. We probably should restrict some of the existing ones there, e.g. -moz-control-character-visibility and MathML ones.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 1 • 9 years ago

Bug 1207002 part 1 - Use CSS property flag to restrict MathML-related internal properties.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 2 • 9 years ago

Bug 1207002 part 2 - Add pref to allow unsafe rules in content for testing.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 3 • 9 years ago

Bug 1207002 part 3 - Restrict -moz-control-character-visibility to UA sheets only.

	Jonathan Kew [:jfkthame]
	Comment 4 • 9 years ago

Comment on attachment 8668829 [details]
MozReview Request: Bug 1207002 part 3 - Restrict -moz-control-character-visibility to UA sheets only.

:roc, this property was originally your idea, IIRC; what do you think of restricting it like this? Or should we continue to allow authors to override our default (which is set to flip soon...)

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 5 • 9 years ago

Comment on attachment 8668827 [details]
MozReview Request: Bug 1207002 part 1 - Use CSS property flag to restrict MathML-related internal properties.

https://reviewboard.mozilla.org/r/21063/#review19025

::: layout/style/nsCSSParser.cpp
(Diff revision 1)
> -  // We only allow 'script-level' when unsafe rules are enabled, because
> -  // otherwise it could interfere with rulenode optimizations if used in
> -  // a non-MathML-enabled document. We also only allow math-display when

Please move this comment to nsCSSPropList.h (for 'script-level') rather than just deleting it.

r=dbaron with that

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 6 • 9 years ago

Could you explain why you want patch 2?

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 7 • 9 years ago

For allowing the reftests of -moz-control-character-visibility (which is flagged in patch 3) to be run. If we do not want to restrict that property, or we can remove those tests, we would not need patch 2.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 8 • 9 years ago

I suggest not landing patches 2 and 3. Hopefully soon we'll flip the default, then some time after that we can just remove the property entirely since it will always be 'visible'.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/05566a80f2ce3792ce5b14a7cf98bf7e131bbb1b
Bug 1207002 - Use CSS property flag to restrict MathML-related internal properties. r=dbaron

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/05566a80f2ce

	Kohei Yoshino [:kohei]
	Comment 11 • 9 years ago

Posted the site compatibility doc just in case: https://www.fxsitecompat.com/en-US/docs/2015/several-internal-css-properties-have-been-removed/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 12 • 9 years ago

(In reply to Kohei Yoshino [:kohei] from comment #11)
> Posted the site compatibility doc just in case:
> https://www.fxsitecompat.com/en-US/docs/2015/several-internal-css-properties-
> have-been-removed/

Please note that it is decided not to remove -moz-control-character-visibility for now. You may want to correct the post.

	Kohei Yoshino [:kohei]
	Comment 13 • 9 years ago

Thanks for the info. Removed -moz-control-character-visibility from the doc.