Closed Bug 1206655 Opened 9 years ago Closed 9 years ago

[Clock] It is 12-hour time format, but it shows as 24-hour format in clock app 'Time' option.

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 unaffected, b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- verified

People

(Reporter: yelanying, Assigned: zbraniecki)

References

Details

(Keywords: regression, Whiteboard: [Spark])

Attachments

(4 files)

Attached image Flame KK_v2.5.png
[1.Description]:
[Flame KK v2.5][Clock] Launch clock app, you will find it shows as 24-hour format in clock app 'Time' option, but it is 12-hour time format infact.
Time: 15:35
See attachments:logcat_1535.txt and Flame KK_v2.5.png

[2.Testing Steps]: 
Precondition: 
1)There is no SIM card in device, and 'Date&Time' is set as automatically.
2) 'Date&Time' is set as automatically and turn on 'Use Default'.

1.Launch clock app.
2.Press the add alarm icon at the top-right corner.

[3.Expected Result]: 
2.In 'Time'  option, it should display as 12-hour time format.

[4.Actual Result]: 
2.In 'Time'  option, it displays as 24-hour time format.

[5.Reproduction build]: 
Flame KK v2.2(Unaffected):
Build ID               20150920032503
Gaia Revision          95950c9d48ad2fc2da7686c2b133b750a99cd3da
Gaia Date              2015-09-18 09:55:13
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/38d6133e2416
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150920.065310
Firmware Date          Sun Sep 20 06:53:21 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame KK v2.5(Affected):
Build ID               20150920150205
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150920.182952
Firmware Date          Sun Sep 20 18:30:04 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


Aries KK v2.5(Unaffected):
Build ID               20150920050928
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150920.042926
Firmware Date          Sun Sep 20 04:29:33 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free test
Attached file logcat_1535.txt
I *am* seeing this occur on the latest Aries 2.5 Master build.  Furthermore, this issue also occurs in the Calendar app, when creating or editing a new event.

Adding regression keyword.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150921142023
Gaia: 2d370fa35c1a0ee2a637e3772c0843586a5f96c9
Gecko: fcef8ded82219c89298b4e376cfbdfba79a1d35a
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: regression
Summary: [Flame KK][Clock] It is 12-hour time format, but it shows as 24-hour format in clock app 'Time' option. → [Clock] It is 12-hour time format, but it shows as 24-hour format in clock app 'Time' option.
Time should be consistent across all apps. Nominating this 2.5?
blocking-b2g: --- → 2.5?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Whiteboard: [Spark]
Zigi, perhaps you know which pull request this caused?
QA Contact: jthomas
Flags: needinfo?(gandalf)
B2g Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150917085051
Gaia: a9993f86d03f806468e9efaf1410785e2c95e398
Gecko: 0cf9f2702772356d8bece743be6fec9cc206ad5d
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150917105352
Gaia: 25b41ead8e05f2f7341e9e0dd25326eed2b94b7d
Gecko: 04cd55ee0dfca005d564038f3fb767a31bf6494e
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working gaia / First Broken gecko - This issue does NOT occur with broken Gecko
Gaia: a9993f86d03f806468e9efaf1410785e2c95e398
Gecko: 04cd55ee0dfca005d564038f3fb767a31bf6494e

Last Working gecko / First Broken gaia - This issue DOES occur with broken Gaia
Gecko: 0cf9f2702772356d8bece743be6fec9cc206ad5d
Gaia: 25b41ead8e05f2f7341e9e0dd25326eed2b94b7d

B2g Inbound Pushlog:
https://github.com/mozilla-b2g/gaia/compare/a9993f86d03f806468e9efaf1410785e2c95e398...25b41ead8e05f2f7341e9e0dd25326eed2b94b7d

This issue is caused by Bug 1187539
Blocks: 1187539
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
Yup, taking! I have a patch to refactor Clock to follow the new spec.
Assignee: nobody → gandalf
Flags: needinfo?(gandalf)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
Comment on attachment 8663899 [details] [review]
[gaia] zbraniecki:1206655-resolve-hour12-using-intl > mozilla-b2g:master

Marcus, I'm working on moving all apps from our custom mozL10n.DateTimeFormat to Intl API.

I have a bigger patch for Clock that migrates the app and cleans up a lot of L10n/Intl API in it (and gets it ready for l20n), but it's not ready yet.

So this patch is just the piece that fixes the regression. Intl API resolvedOptions() returns the proper hour12 setting for automatic scenario.
Attachment #8663899 - Flags: review?(m)
Comment on attachment 8663899 [details] [review]
[gaia] zbraniecki:1206655-resolve-hour12-using-intl > mozilla-b2g:master

Works for me... thanks for the interim fix!
Attachment #8663899 - Flags: review?(m) → review+
Thanks!

Commit: https://github.com/mozilla-b2g/gaia/commit/2e02c0340a1fc6097e63d3e1495bfefd01b2b382
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Hi Jessica,

Verifyme, thanks.
Flags: needinfo?(yelanying)
Keywords: verifyme
According to the STR of Comment 0, this bug has been verified as pass on latest Flame KK v2.5.

Actual results: In 'Time'  option, it should display as 12-hour time format.
See attachment: verified_Aries KK v2.5.png
Reproduce rate: 0/6


Device: Flame KK v2.5(Pass)
Build ID               20150922150204
Gaia Revision          68361828ae88dffd04b250121b5f2472a63f4bf0
Gaia Date              2015-09-22 03:46:57
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a1ccea59e254a88f7bb44b0ad8a58b77b7eca339
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150922.183124
Firmware Date          Tue Sep 22 18:31:40 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
Flags: needinfo?(yelanying)
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+], [MGSEI-Triage+]
blocking-b2g: 2.5? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: