Jessica Reporter
	Description • 9 years ago

[1.Description]:
[Aries KK v2.5][Hackerplace] Hackerplace app is unuseable when you launch it.

Time: 01:00
See attachments:logcat_0100.txt and Aries_KK v2.5.3gp

[2.Testing Steps]: 
1.Launch Hackerplace app.

[3.Expected Result]: 
1.It can be useable.

[4.Actual Result]: 
1.It's unuseable.

[5.Reproduction build]: 
Device: Aries KK 2.5 user [Affected]
Build ID               20150917232249
Gaia Revision          2082894c8e974b0c371e4dec298e0ad0f3ac56b1
Gaia Date              2015-09-17 14:56:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/01a75ffad1024a3f75d494fb77a022c96a497eb2
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150917.224210
Firmware Date          Thu Sep 17 22:42:18 UTC 2015
Bootloader             s1

Device: Aries KK 2.5 eng [Affected]
Build ID               20150917232610
Gaia Revision          2082894c8e974b0c371e4dec298e0ad0f3ac56b1
Gaia Date              2015-09-17 14:56:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/01a75ffad1024a3f75d494fb77a022c96a497eb2
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150917.224608
Firmware Date          Thu Sep 17 22:46:16 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
16424

[8.Note]:
Flame KK v2.5 dosen't have this app.

	Norry.L.F(Leave from Mozilla)
	Comment 2 • 9 years ago

Hi William,

Could you have someone to take a look at this bug? The bug seems to fail TCID 16424.
" Case #16424
Title: Ensure the supported Spark Apps launch
Step: 1. Launch Customizer, Sharing, Webmaker, Hackerplace, Studio, BuddyUp and Bugzilla Lite
>>Each app launches and is usable.
"

	William Hsu [:whsu]
	Comment 3 • 9 years ago

I saw many errors on the log

09-18 00:32:05.845 W/Marketplace( 3022): [JavaScript Warning: "Error in parsing value for 'display'.  Declaration dropped." {file: "https://marketplace.cdn.mozilla.net/media/fireplace/css/include.css?b=1442340905908" line: 46 column: 439 source: ".games-home{display:-webkit-box;display:-webkit-flex;display:-moz-box;display:-ms-flexbox;display:flex;height:100%;-webkit-flex-wrap:wrap;-ms-flex-wrap:wrap;flex-wrap:wrap;-webkit-box-pack:center;-webkit-justify-content:center;-moz-box-pack:center;-ms-flex-pack:center;justify-content:center;width:100%}.games-home>section{padding:30px 120px;width:100%}.games-home-primary{display:-webkit-box;display:-webkit-flex;display:-moz-box;display:-ms-flexbox;display:flex;-webkit-box-orient:vertical;-webkit-box-directio"}]

	William Hsu [:whsu]
	Comment 4 • 9 years ago

Also, I saw the error while I reproduced this bug.


E/Hackerplace( 1974): [JavaScript Error: "SyntaxError: import declarations may only appear at top level" {file: "app://directory.gaiamobile.org/js/app.js" line: 1 column: 0 source: "import 'js/globals';
E/Hackerplace( 1974): "}]

	Dylan Oliver [:doliver]
	Comment 5 • 9 years ago

triage: blocking for white screen, app is dead in the water. Marking this P1 as long as hackerplace is distributed with the Aries build.

	Hema Koka [:hema]
	Comment 6 • 9 years ago

Doug/Kevin,

Mhenretty is ooo. And I believe Naoki is working on backing out the patch that may have caused this issue.  Can one of you please help take a look if the backout does not help here. 

This is holding up dogfood builds.

Thanks a lot!

Hema

	Doug Sherk (:drs) (inactive)
	Comment 8 • 9 years ago

Comment on attachment 8664387 [details] [review]
revert hackerplace, add mozspeech

I assume that this is just a straight revert of that commit without the mozspeechcollect stuff removed as well.

	Doug Sherk (:drs) (inactive)
	Comment 9 • 9 years ago

Comment on attachment 8664387 [details] [review]
revert hackerplace, add mozspeech

I've confirmed that this works, so it'll do for now.

	Doug Sherk (:drs) (inactive)
	Comment 10 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/5f67c62ccacb9e9ae6f5989ef9fdcd8ed5c2515e

	Martin Shuman [:Marty]
	Comment 11 • 9 years ago

This issue IS still occurring on the latest Aries 2.5 Master build.

Hackerplace is still launching as a blank screen with a repro rate of approximately 46/50 attempts.  I have intermittently been able to launch the app and see the app UI properly, but the majority of the times the app is launched, only a blank screen is displayed.


Environmental Variables:
Device: Aries 2.5
BuildID: 20150924111215
Gaia: 4bb17b24620818cbda0ba0c0d69e0ce3f914e1b7
Gecko: 001942e4617b2324bfa6cdfb1155581cbc3f0cc4
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 12 • 9 years ago

Let's make sure this issue was actually caused by the reverted commit.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 16 • 9 years ago

Comment on attachment 8665690 [details] [diff] [review]
[Directory] Add "moz-extremely-unstable-and-will-change-webcomponents" permission.

This is needed I think in that repo.  Having said that, it's already added in the app in the main gaia repo.  There's something else that's causing the white out...

	Pi Wei Cheng [:piwei] (inactive)
	Comment 17 • 9 years ago

b2g-inbound regression window:

Last Working
Device: Aries 2.5
BuildID: 20150917052413
Gaia: aede8622d780ec71f766a3ecccbff74c04aaba4e
Gecko: 8d4c37a86b576db4ef150dff715a89ff77e84bf5
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Device: Aries 2.5
BuildID: 20150917070524
Gaia: eb62d50351fd6a9b560fe369387d8138b9b3a2d3
Gecko: bd9c944ed8add573d1fdeaf7dcc3ed424e8bdad1
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working Gaia First Broken Gecko - no repro
Gaia: aede8622d780ec71f766a3ecccbff74c04aaba4e
Gecko: bd9c944ed8add573d1fdeaf7dcc3ed424e8bdad1

Last Working Gecko First Broken Gaia - repro
Gaia: eb62d50351fd6a9b560fe369387d8138b9b3a2d3
Gecko: 8d4c37a86b576db4ef150dff715a89ff77e84bf5

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/aede8622d780ec71f766a3ecccbff74c04aaba4e...eb62d50351fd6a9b560fe369387d8138b9b3a2d3

Caused by Gaia commit eb62d50351fd6a9b560fe369387d8138b9b3a2d3

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 18 • 9 years ago

Naoki and Doug, please take a look at the pushlog from comment 17

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 19 • 9 years ago

We already reverted and it's still not working correctly.  It's something else.

Even with that as a benefit of the doubt, I also checked via reverting to a previous hash and copying and pushing to make sure it wasn't any file change difference.

Something else is causing the issue to occur.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 20 • 9 years ago

So I found out by flashing a 9/16 gaia on top of 9/18 that the first instance of the white out was caused by this regression.  We had backed out of this change.  There's something in the gecko that's causing a second regression with the same issue as I flashed a 9/16 gaia on top of today's gecko and I still get the white out.

I'm trying to find the regression range for the second break.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 21 • 9 years ago

Regression range currently : 

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=46842118f0c94cb300d0eb7416dddf43b777dbab&tochange=0f498d5adbf959b6743f76acc849d87ecb26f19f

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 22 • 9 years ago

Note the initial revert in comment 10 should be build : 20150923112734 
full flash on this build ( https://tools.taskcluster.net/task-inspector/DYjiv3iSQH6kz258oxIkcQ ) and 20150923212638 - https://tools.taskcluster.net/task-inspector/#SI6Mjk7iS4-mZvBpKyeoHw/ yield the hackerplace display.

Smaller regression range : 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1450aeb716933121ad4a1074eee36d4bb1040b1e&tochange=0f498d5adbf959b6743f76acc849d87ecb26f19f

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 23 • 9 years ago

To note, here are the builds I used:
** good - 20150923212638 - https://tools.taskcluster.net/task-inspector/#SI6Mjk7iS4-mZvBpKyeoHw/
**  bad - 20150924110728 - https://tools.taskcluster.net/task-inspector/#ZxFF_mVBSSO01bbRGTJEJg/

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 24 • 9 years ago

Smaller regression window : 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1450aeb716933121ad4a1074eee36d4bb1040b1e&tochange=f1dffc8682fb

Based on build :  https://tools.taskcluster.net/task-inspector/#P7W-8TSATIOwvaOmAFAvNw/

Creating build : https://tools.taskcluster.net/task-inspector/#CBmKQi-FSUa2RX5o_9JM4g/
to see if the root cause is : http://hg.mozilla.org/mozilla-central/rev/f1dffc8682fb

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 25 • 9 years ago

Mozregression points to : http://hg.mozilla.org/mozilla-central/rev/015612bc2208

Trying to do backout on a self made build / Making FOTA at the same time : https://tools.taskcluster.net/task-inspector/#W2Pwkz23QdCrCeOvCRL5fA/2

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 26 • 9 years ago

Looking at the patch... that doesn't make sense...

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 27 • 9 years ago

I'm pretty sure this commit caused the regression [1]. When spark-bot deployed the hackerplace, it did so with the un-built javascript files. We need to first build the hackerplace, and then use the javascript files in the /dist/ folder of the hackerplace repo in gaia.

1.) https://github.com/mozilla-b2g/gaia/commit/eb62d50351fd6a9b560fe369387d8138b9b3a2d3

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 28 • 9 years ago

Comment on attachment 8665690 [details] [diff] [review]
[Directory] Add "moz-extremely-unstable-and-will-change-webcomponents" permission.

I'll merge this. Thanks Doug.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 29 • 9 years ago

Naoki, let me know if I can help out here with building hackerplace.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 31 • 9 years ago

Spoke with Michael, he's helping out.  

recap: there are two regressions : one from trying to push a new hackerplace which a backout had fixed, then a second white out issue.  There's a permission that needs to be added which Michael has done in the app source tree which is what the patch is.  The patch does not fix the issue.

Michael is investigating the possibility of a race condition, which would make a regression window hard to find/useless.  I confirmed that the regression window I had in comment 24 is wrong.

Once we get that issue resolved, I think we'll work on updating the hackerplace in general?

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 32 • 9 years ago

Comment on attachment 8667349 [details] [review]
[gaia] mikehenrty:bug-1206028-deploy-hackerplace > mozilla-b2g:master

Naoki, can you see if this deploy of hackerplace fixes the issue?

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 33 • 9 years ago

Cherry picked Michael's patch.  It seems that install-gaia didn't make the hackerplace show, reset-gaia however did.  Not sure if that will make a difference.

Kicked off a build : https://tools.taskcluster.net/task-inspector/#MtsglCSmSduiLQM606y7Vw/
for aries FOTA with mhenretty's patch.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 34 • 9 years ago

Comment on attachment 8667349 [details] [review]
[gaia] mikehenrty:bug-1206028-deploy-hackerplace > mozilla-b2g:master

The patch makes a successful marketplace build and view; even updating from RC4 will show the app properly.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 35 • 9 years ago

ok, merged the hackerplace fix into master:

https://github.com/mozilla-b2g/gaia/commit/f4d1301790c616f5ef871272ccb76f35c898e32b

sounds like we'll have a foxfood update soon \o/

	Adam Alldredge [:AdamA][Inactive]
	Comment 36 • 9 years ago

This issue is verified fixed in Aries 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151001114357
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 2c1fb007137dcb68b1862a79553b53f1a34c99c3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
The hackerplace app opens correctly.