Jarda Snajdr [:jsnajdr] Assignee
	Comment 5 • 8 years ago

Part 1: backend
- added removeDatabase method to the actor. As there are no change events in indexedDB we could listen to, we need to update the hostVsStores map and send the "deleted" event to UI directly in the method.
- added removeDB method to indexedDBHelpers. This method does the heavy lifting, in the process script.
- the "patchMetadataMapsAndProtos" function is not part of the child-parent API, doesn't need to be assigned anywhere in the maybeSetupChildProcess call.

Part 2: Bugfix in the TreeWidget
- when a last child of a tree item is deleted, it shouldn't have the expander arrow anymore. Added code that sets the "empty" attribute on the parent item, plus test.

Part 3: Frontend UI
- added new delete action to the tree context menu, show it on an indexedDB database tree item
- fixed the handleDeletedItems method, so that it can handle removing a whole database from the tree

Part 4: Mochitest

	Jarda Snajdr [:jsnajdr] Assignee
	Comment 6 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dea8527fa3cb

	Jarda Snajdr [:jsnajdr] Assignee
	Comment 7 • 8 years ago

Fixed return value of removeDB - make it work both in e10s and non-e10s mode.

	Jarda Snajdr [:jsnajdr] Assignee
	Comment 8 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37b5601388f2

	Jarda Snajdr [:jsnajdr] Assignee
	Comment 9 • 8 years ago

Try run is 100% green, requesting checkin. There are parts 1 to 4, but order shouldn't matter.

	Sebastian Zartner [:sebo] Reporter
	Comment 10 • 8 years ago

Sorry, meant to add the keyword to bug 1231449.

Sebastian

	Jarda Snajdr [:jsnajdr] Assignee
	Comment 12 • 8 years ago

(In reply to Sebastian Zartner [:sebo] from comment #10)
> Sorry, meant to add the keyword to bug 1231449.

Both frontend and backend were implemented as part of this bug, marked bug 1231449 as duplicate. Adding the dev-doc-needed keyword here. Sorry for the confusion.

	Pulsebot
	Comment 13 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/a7a25d56bd3a
https://hg.mozilla.org/integration/fx-team/rev/937b169893c1
https://hg.mozilla.org/integration/fx-team/rev/4e204ca5848c
https://hg.mozilla.org/integration/fx-team/rev/38b63eafc2ca

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 14 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a7a25d56bd3a
https://hg.mozilla.org/mozilla-central/rev/937b169893c1
https://hg.mozilla.org/mozilla-central/rev/4e204ca5848c
https://hg.mozilla.org/mozilla-central/rev/38b63eafc2ca

	Sebastian Zartner [:sebo] Reporter
	Comment 15 • 8 years ago

Works fine for me on http://blog.vanamco.com/indexeddb-fundamentals-plus-a-indexeddb-example-tutorial/, but fails to properly handle the case when the DB is blocked. Created bug 1268460 to handle this.

Added documentation for this at https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector#IndexedDB and a release note at https://developer.mozilla.org/en-US/Firefox/Releases/49.

Sebastian