Trevor Saunders (:tbsaunde) Assignee
	Description • 9 years ago

      No description provided.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 2 • 9 years ago

Comment on attachment 8660049 [details] [diff] [review]
add a little more checking to proxy subtree removal

Review of attachment 8660049 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one change requested inline below:

::: accessible/ipc/DocAccessibleParent.cpp
@@ +109,5 @@
> +  // We shouldn't actually need this because mAccessibles shouldn't have an
> +  // entry for the document itself, but it doesn't hurt to be explicit.
> +  if (!aRootID) {
> +    NS_ERROR("trying to hide entire document?");
> +    return false;

Please return true here. Returning false destroys the world I think.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 3 • 9 years ago

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 8660049 [details] [diff] [review]
> add a little more checking to proxy subtree removal
> 
> Review of attachment 8660049 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with one change requested inline below:
> 
> ::: accessible/ipc/DocAccessibleParent.cpp
> @@ +109,5 @@
> > +  // We shouldn't actually need this because mAccessibles shouldn't have an
> > +  // entry for the document itself, but it doesn't hurt to be explicit.
> > +  if (!aRootID) {
> > +    NS_ERROR("trying to hide entire document?");
> > +    return false;
> 
> Please return true here. Returning false destroys the world I think.

which we want to do here (at least until we find it exposes a bunch of content side bugs we need to hack around)

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 4 • 9 years ago

Maybe Maybe MOZ_DIAGNOSTIC_ASSERT(aRoodID) is good?

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d8da59723c3

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6d8da59723c3