Martijn Wargers (dead) Reporter
	Description • 9 years ago

From Yura on irc, I understood that the original source code of atoms.js comes from:
https://code.google.com/p/selenium/source/browse/javascript/atoms/

I think it would be nice if atoms.js would contain a link to that url, because atoms.js is very difficult to read.

	Martijn Wargers (dead) Reporter
	Comment 1 • 9 years ago

https://github.com/seleniumhq/selenium is actually the official repo now.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 9 years ago

We definitely want to make it easier to understand where the atoms come from.  The problem right now is that nobody knows exactly how the current atoms were compiled.

The background story: About two years ago I spent significant effort and time writing atom generation targets for Selenium.  You can check out Selenium and run `./go marionette:atoms` to see this.  Unfortunately I discovered only in retrospect that this generated atoms that were very different from the ones used by Marionette.  Trying to upgrade the atoms caused a lot of breakage which I at that point didn’t have the time to look into.

The right thing to do here would be to figure out what atoms we want, define the generation rules in Selenium, add a comment in the generated file where to go look for the source and how to generate them &c., and fix the problems related to upgrading the atoms.

	Martijn Wargers (dead) Reporter
	Comment 3 • 9 years ago

Ugh, that sounds complicated.
Not sure what automated test suites there are currently out there that use Marionette and use the atoms.js file.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 9 years ago

(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> Not sure what automated test suites there are currently out there that use
> Marionette and use the atoms.js file.

For the WebDriver functionality of clearing an element and determining if an element is displayed, we use the atoms.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 7 years ago

In the long-term we want to delete testing/marionette/atom.js from the tree in its entirety, but there are a few things preventing us from doing so.  This is being tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1354203.

As part of https://bugzilla.mozilla.org/show_bug.cgi?id=1354201, https://bugzilla.mozilla.org/show_bug.cgi?id=1321516, and https://bugzilla.mozilla.org/show_bug.cgi?id=1275273 I will however get rid of individual JS fragments in the file, even if it means we cannot get rid of everything quite yet.

However, I do think it’s worthwhile to point out where the source of the fragments originate from, and we can do this in the interim.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8855413 [details]
Bug 1203966 - Include links to unminified source of JS fragment atoms;

https://reviewboard.mozilla.org/r/127256/#review130426

	Pulsebot
	Comment 8 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a6826c22e05
Include links to unminified source of JS fragment atoms; r=maja_zf

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 9 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9a6826c22e05