Eitan Isaacson [:eeejay] Assignee
	Description • 9 years ago

Besides form controls, it should also navigate to links.

	Yura Zenevich [:yzen] (please use "needinfo")
	Comment 2 • 9 years ago

Comment on attachment 8659476 [details] [diff] [review]
Introduce Android "Control" traversal rule.

Review of attachment 8659476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, see my comments. Also a traversal test example would be a +.

::: accessible/jsat/Traversal.jsm
@@ +313,5 @@
> +     Roles.SLIDER,
> +     Roles.CHECKBUTTON,
> +     Roles.CHECK_MENU_ITEM,
> +     Roles.SWITCH,
> +     Roles.LINK],

You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and ROWHEADER (sorting)

@@ +320,5 @@
> +      // We want to ignore anchors, only focus real links.
> +      if (aAccessible.role == Roles.LINK &&
> +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> +        return Filters.IGNORE;
> +      }

Perhaps also check an action count? AFAIK, if control is disabled it will look as if there are no actions available.

	Eitan Isaacson [:eeejay] Assignee
	Comment 3 • 9 years ago

(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8659476 [details] [diff] [review]
> Introduce Android "Control" traversal rule.
> 
> Review of attachment 8659476 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, see my comments. Also a traversal test example would be a +.
> 
> ::: accessible/jsat/Traversal.jsm
> @@ +313,5 @@
> > +     Roles.SLIDER,
> > +     Roles.CHECKBUTTON,
> > +     Roles.CHECK_MENU_ITEM,
> > +     Roles.SWITCH,
> > +     Roles.LINK],
> 
> You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and
> ROWHEADER (sorting)
> 
> @@ +320,5 @@
> > +      // We want to ignore anchors, only focus real links.
> > +      if (aAccessible.role == Roles.LINK &&
> > +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> > +        return Filters.IGNORE;
> > +      }
> 
> Perhaps also check an action count? AFAIK, if control is disabled it will
> look as if there are no actions available.

I don't think we should necessarily skip disabled form controls.

	Eitan Isaacson [:eeejay] Assignee
	Comment 4 • 9 years ago

Added test and Role.MENUITEM to rule.

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e610b46e85

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/a2e610b46e85