Closed Bug 1200961 Opened 9 years ago Closed 9 years ago

switching to the modal view doesn't force the mozilla skin

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

switching to the modal view doesn't force the mozilla skin.

the code exists in the extension, but the hook was never added to Bugzilla/User/Setting.pm
We have a similar use case, where certain settings are inter-related. 
Being able to alter the settings object before it is returned by get_all_settings() would allow for using hierarchies in settings as well (toggle multiple child settings with a single parent)

Would this hook be something to propose for upstream as well?
Attached patch 1200961_1.patchSplinter Review
Attachment #8655851 - Flags: review?(dkl)
Comment on attachment 8655851 [details] [diff] [review]
1200961_1.patch

Review of attachment 8655851 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8655851 - Flags: review?(dkl) → review+
(In reply to Colin Joy from comment #1)
> Would this hook be something to propose for upstream as well?

upstream may well be interested if you file a bug there.



To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a6c5ec6..3eec411  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: