:glob ✱ Assignee
	Description • 9 years ago

add printable recovery 2fa codes

	:glob ✱ Assignee
	Comment 1 • 9 years ago

- add ability to generate codes
- allows codes to be used anywhere 2fa is required
- minor fixes (uninit warnings, printing tweaks)

	Dylan Hardison [:dylan] (he/him)
	Comment 2 • 9 years ago

Comment on attachment 8664662 [details] [diff] [review]
1199090_1.patch

Review of attachment 8664662 [details] [diff] [review]:
-----------------------------------------------------------------

r- because inconsistent calling convention of verify_check() -- in one place it is called with no arguments,
and in another with arguments. The behavior seems fine but I'd like that to be fixed before I finish reviewing it.

::: Bugzilla/MFA.pm
@@ +90,5 @@
> +}
> +
> +# methods
> +
> +sub generate_recovery_codes {

nit 1: I don't think we really need three loops here. 
nit 2: the first loop doesn't conform to our usual coding conventions.

::: userprefs.cgi
@@ +675,5 @@
>          clear_settings_cache(Bugzilla->user->id);
>      }
> +
> +    elsif ($action eq 'recovery') {
> +        $user->mfa_provider->verify_check(Bugzilla->input_params);

Argument passed to method is not used.

@@ +686,2 @@
>      else {
> +        $user->mfa_provider->verify_check(Bugzilla->input_params);

Argument passed to method is not used by method.

	:glob ✱ Assignee
	Comment 3 • 9 years ago

- actually use the passed param
- simplify code generation

	Dylan Hardison [:dylan] (he/him)
	Comment 4 • 9 years ago

Comment on attachment 8665259 [details] [diff] [review]
1199090_2.patch

Review of attachment 8665259 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

	:glob ✱ Assignee
	Comment 5 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   87c32cb..05fed61  master -> master