Closed
Bug 1195471
Opened 9 years ago
Closed 9 years ago
make getChildCountCB work with proxies
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(2 files)
5.66 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
5.70 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8648898 -
Flags: review?(dbolter)
Comment 2•9 years ago
|
||
Comment on attachment 8648898 [details] [diff] [review] make getChildCountCB work with proxies Review of attachment 8648898 [details] [diff] [review]: ----------------------------------------------------------------- r=me with note and nit. ::: accessible/atk/AccessibleWrap.cpp @@ +830,5 @@ > return static_cast<gint>(accWrap->EmbeddedChildCount()); > + } > + > + ProxyAccessible* proxy = GetProxy(aAtkObj); > + return proxy->MustPruneChildren() ? 0 : proxy->EmbeddedChildCount(); OK if you are sure that if GetAccessibleWrap fails means GetProxy will always succeed. ::: accessible/ipc/DocAccessibleChild.h @@ +434,5 @@ > > virtual bool RecvTakeFocus(const uint64_t& aID) override; > > + virtual bool RecvEmbeddedChildCount(const uint64_t& aID, uint32_t* aCount) > + override final; Please a start new line for the second param (like surrounding method formats).
Attachment #8648898 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to David Bolter [:davidb] from comment #2) > Comment on attachment 8648898 [details] [diff] [review] > make getChildCountCB work with proxies > > Review of attachment 8648898 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=me with note and nit. > > ::: accessible/atk/AccessibleWrap.cpp > @@ +830,5 @@ > > return static_cast<gint>(accWrap->EmbeddedChildCount()); > > + } > > + > > + ProxyAccessible* proxy = GetProxy(aAtkObj); > > + return proxy->MustPruneChildren() ? 0 : proxy->EmbeddedChildCount(); > > OK if you are sure that if GetAccessibleWrap fails means GetProxy will > always succeed. err, that's a bug, but obviously returning 0 is what should happen if its null so I'll fix that > > ::: accessible/ipc/DocAccessibleChild.h > @@ +434,5 @@ > > > > virtual bool RecvTakeFocus(const uint64_t& aID) override; > > > > + virtual bool RecvEmbeddedChildCount(const uint64_t& aID, uint32_t* aCount) > > + override final; > > Please a start new line for the second param (like surrounding method > formats). I don't think that is the format? I'd say its put as much as possible on a line up to 80 chars then break reasonably as usual. Though there is some stuff that seems to not follow that...
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00d7cf364086
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Assignee | ||
Comment 6•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•