Trevor Saunders (:tbsaunde) Assignee
	Description • 9 years ago

      No description provided.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 1 • 9 years ago

This will enable us to remove the virtual function GetModifiedText().

	Trevor Saunders (:tbsaunde) Assignee
	Comment 2 • 9 years ago

There's no point in this indirection since ia2AccessibleText has direct access
to this data.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 3 • 9 years ago

Soon we will need to be able to update the text change event data from both
 HandleAccEvent() and ProxyTextChangeEvent(), so separate out the logic to do
 that into a function.

	alexander :surkov (:asurkov)
	Comment 4 • 9 years ago

Comment on attachment 8645054 [details] [diff] [review]
add ia2AccessibleText::UpdateTextChangeData

Review of attachment 8645054 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/windows/msaa/HyperTextAccessibleWrap.cpp
@@ +58,5 @@
> +          static_cast<HyperTextAccessibleWrap*>(accessible->AsHyperText());
> +      ia2AccessibleText::UpdateTextChangeData(text, event->IsTextInserted(),
> +                                              event->ModifiedText(),
> +                                              event->GetStartOffset(),
> +                                              event->GetLength());

it might nicer if UpdateTextChangeData was taking AccTextChangeEvent as argument, at least less variables on stack.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 5 • 9 years ago

(In reply to alexander :surkov from comment #4)
> Comment on attachment 8645054 [details] [diff] [review]
> add ia2AccessibleText::UpdateTextChangeData
> 
> Review of attachment 8645054 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/windows/msaa/HyperTextAccessibleWrap.cpp
> @@ +58,5 @@
> > +          static_cast<HyperTextAccessibleWrap*>(accessible->AsHyperText());
> > +      ia2AccessibleText::UpdateTextChangeData(text, event->IsTextInserted(),
> > +                                              event->ModifiedText(),
> > +                                              event->GetStartOffset(),
> > +                                              event->GetLength());
> 
> it might nicer if UpdateTextChangeData was taking AccTextChangeEvent as
> argument, at least less variables on stack.

but ProxyTextChangeEvent() doesn't have one so it wouldn't work there.

	Pulsebot
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c1af6e4c004
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b9c388f05a
https://hg.mozilla.org/integration/mozilla-inbound/rev/1409d0fcea5d
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f76881caf22

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 8 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/5c1af6e4c004
https://hg.mozilla.org/mozilla-central/rev/d5b9c388f05a
https://hg.mozilla.org/mozilla-central/rev/1409d0fcea5d
https://hg.mozilla.org/mozilla-central/rev/2f76881caf22